chore: dedupe build.zig (-79 lines)#90
Merged
Merged
Conversation
Three duplications collapsed into one shape each: - 14 nearly-identical example/bench scaffolding blocks now go through a single addZoltExe helper (executable + run step + step alias). - WASM export symbol list was duplicated between the atomics and non-atomics branches; now expressed as base ++ TLS-extras. - The zig fmt path list lived in two places (fmt step and ci step's fmt_check); lifted into a shared fmt_paths constant. No behavior change. zig build, zig build example-field, and zig fmt --check build.zig all pass; all 14 example/bench steps still appear in zig build --help. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three duplications in
build.zigcollapsed into one shape each, no behavior change:addZoltExehelper. Each block was 13 lines ofaddExecutable+addRunArtifact+b.step+dependOn; now ~9 lines of named-options.base ++ TLS-extrasso the shared 15 symbols live in one place.zig fmtpath list appeared in both thefmtstep and thecistep'sfmt_check. Lifted into a top-levelfmt_pathsconstant.Net: 646 → 567 lines (-79).
Test plan
zig buildpasseszig build example-fieldbuilds and runs successfullyzig fmt --check build.zigcleanzig build --helpstill lists all 14 example/bench steps🤖 Generated with Claude Code