From b63fb59544c5645f9fe71780b52754ed6e9b6fd6 Mon Sep 17 00:00:00 2001 From: lukasz-matter Date: Tue, 23 Apr 2024 14:58:54 +0200 Subject: [PATCH] Remove redundant test --- matter_observability/fastapi/utils.py | 8 +++----- tests/fastapi/test_configure_middleware.py | 9 --------- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/matter_observability/fastapi/utils.py b/matter_observability/fastapi/utils.py index 5ffdc33..0c1ee27 100644 --- a/matter_observability/fastapi/utils.py +++ b/matter_observability/fastapi/utils.py @@ -10,8 +10,6 @@ def configure_middleware(app: FastAPI, skip_paths: list[str] | None = None) -> N app.middleware("http")(process_request_id) - Instrumentator( - excluded_handlers=skip_paths, - should_respect_env_var=True, - env_var_name="ENABLE_METRICS" - ).instrument(app=app).expose(app=app, endpoint=metrics_path) + Instrumentator(excluded_handlers=skip_paths, should_respect_env_var=True, env_var_name="ENABLE_METRICS").instrument( + app=app + ).expose(app=app, endpoint=metrics_path) diff --git a/tests/fastapi/test_configure_middleware.py b/tests/fastapi/test_configure_middleware.py index b6f5291..7ad613b 100644 --- a/tests/fastapi/test_configure_middleware.py +++ b/tests/fastapi/test_configure_middleware.py @@ -1,20 +1,11 @@ from unittest.mock import Mock -import pytest from fastapi import FastAPI from pytest_mock import MockerFixture -from prometheus_fastapi_instrumentator import Instrumentator -from matter_observability.exceptions import MisConfigurationError from matter_observability.fastapi import configure_middleware -def test_configure_middleware_throws_exception_if_enable_metrics_is_not_set(mocker: MockerFixture): - mocker.patch("matter_observability.config.Config.INSTANCE_NAME", None) - with pytest.raises(MisConfigurationError): - configure_middleware(FastAPI()) - - def test_configure_middlewares_does_not_add_prometheus_middleware_if_enable_metrics_is_not_set(mocker: MockerFixture): mocker.patch("matter_observability.config.Config.ENABLE_METRICS", False)