Single quotation mark in annotation causes loss of saved bookmarks #53

Closed
willthefrog opened this Issue Jul 17, 2014 · 2 comments

Projects

None yet

2 participants

@willthefrog

In bm#serialize(), the content field is escaped, but theannotation field is not. If the annotations contain single quotation marks ('), exec join(a:data, " | ") in bm#deserialize() will fail silently, and l:bm_sessions will be overwrite upon VimLeave, causing loss of saved bookmarks. Please fix this.

@willthefrog willthefrog changed the title from single quotation mark in annotation cause loss of all saved bookmarks to single quotation mark in annotation cause loss of saved bookmarks Jul 17, 2014
@MattesGroeger
Owner

Oh no, what a terrible bug! Thanks for reporting @willthefrog

@MattesGroeger MattesGroeger added the bug label Jul 17, 2014
@MattesGroeger MattesGroeger added this to the 1.2.0 milestone Jul 17, 2014
@willthefrog

You are welcome, thanks for this great plugin.

@MattesGroeger MattesGroeger changed the title from single quotation mark in annotation cause loss of saved bookmarks to Single quotation mark in annotation causes loss of saved bookmarks Jul 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment