-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenericSemaphoreAcquireFuture isn't Sync #23
Comments
As I realize that As its unclear if hyper really needs |
Making However there is no real use-case that requires them to be
I think it rather be good to ask on the hyper repository whether that bound is really required. According to rust-lang/futures-rs#1752 it might be able to resolve it by using another |
Thanks. Yes, the use case I describe is situational and hopefully temporary, though I suspect hyper won't change its Since I've implemented a |
The "consistency" statement was just about
I think that's fine to do for a particular use-case! I guess it would show up in the Mutex benchmark that is part of the repo, because even uncontended atomics ops are not free. But it's unlikely that it would cause a real issue in a particular application (although it obviously depends on what you use the Semaphore for). |
Thanks. I think for my use case as described above, an uncontended mutex lock is unlikely to be detectable in the larger performance implications of using the Feel free to close this if you think there is nothing more actionable. Or keep it open so that others can find it? |
Sure!
Thanks! I will close it. I think for visibility reasons there is not really an ideal time to close things. So one can do it as well immediately, in order to avoid the backlog from growing. |
For those interested, see relevant followup in: http://gravitext.com/2020/01/13/blocking-permit.html |
This seems related to #3. Was
Sync
for this type just an oversight, or might it be safely added? I guess the question is, if concurrent access to a*mut ListNode<WaitQueueEntry?
could be safe?Current compile error:
The text was updated successfully, but these errors were encountered: