Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip external #1

Merged
merged 3 commits into from Jun 3, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -30,6 +30,10 @@ mainIndexDocument('[data-react-helmet]').remove();
const template = mainIndexDocument.html();

const skipExternalRequests = async page => {
if(config.includeExternal){
return;
}

await page.setRequestInterception(true);
page.on('request', async request => {
if (request.url().startsWith(config.rootUrl)) {

Some generated files are not rendered by default. Learn more.

@@ -1,6 +1,6 @@
{
"name": "helmet-static",
"version": "1.0.2",
"version": "1.0.3",
"description": "Create a static index.html for your sub pages with rendered helmet attributes",
"main": "index.js",
"scripts": {
@@ -22,7 +22,7 @@
"dependencies": {
"cheerio": "^1.0.0-rc.2",
"mkdirp": "^0.5.1",
"puppeteer": "^1.6.1",
"puppeteer": "^1.17.0",
"queue-batch": "^1.0.2",
"serve-static": "^1.13.2"
},
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.