Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bufferSize parameter to init #30

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
2 participants
@hodovani
Copy link
Collaborator

commented Jan 11, 2019

Add parameter to init function with default value 10mb.

Resolves #26
Resolves #27

@hodovani hodovani self-assigned this Jan 11, 2019

@hodovani hodovani added this to In progress in 0.4 release via automation Jan 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 11, 2019

Codecov Report

Merging #30 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   98.17%   98.18%   +<.01%     
==========================================
  Files           5        5              
  Lines         219      220       +1     
==========================================
+ Hits          215      216       +1     
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/CoreXLSX.swift 97.59% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02d7f4...c93b931. Read the comment docs.

0.4 release automation moved this from In progress to Reviewer approved Jan 11, 2019

@hodovani hodovani merged commit c0e9b4f into master Jan 11, 2019

4 checks passed

codecov/patch 100% of diff hit (target 98.17%)
Details
codecov/project 98.18% (+<.01%) compared to f02d7f4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

0.4 release automation moved this from Reviewer approved to Done Jan 11, 2019

@delete-merged-branch delete-merged-branch bot deleted the feature/init-parametr-bufferSize branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.