Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Worksheet and Pane values to optional #31

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
2 participants
@hodovani
Copy link
Collaborator

commented Jan 11, 2019

Resolves partially #28

hodovani added some commits Jan 11, 2019

@MaxDesiatov MaxDesiatov added this to In progress in 0.4 release via automation Jan 11, 2019

0.4 release automation moved this from In progress to Reviewer approved Jan 11, 2019

0.4 release automation moved this from Reviewer approved to Needs review Jan 11, 2019

0.4 release automation moved this from Needs review to Reviewer approved Jan 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 11, 2019

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files           5        5           
  Lines         220      220           
=======================================
  Hits          216      216           
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/Worksheet/Worksheet.swift 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e9b4f...c5acf8f. Read the comment docs.

@hodovani hodovani merged commit af9d16d into master Jan 11, 2019

4 checks passed

codecov/patch Coverage not affected when comparing c0e9b4f...c5acf8f
Details
codecov/project 98.18% remains the same compared to c0e9b4f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

0.4 release automation moved this from Reviewer approved to Done Jan 11, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix/coding-keys branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.