Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose `errorContextLength` on `struct XLSXFile` #38

merged 1 commit into from Feb 5, 2019


2 participants
Copy link

commented Feb 4, 2019

New version of XMLCoder exposes errorContextLength, which could greatly help with diagnostics. There's now an additional argument with a default value of 0 exposed on XLSXFile initializer.

Resolves #32

@MaxDesiatov MaxDesiatov added this to In progress in 0.4 release via automation Feb 4, 2019

0.4 release automation moved this from In progress to Reviewer approved Feb 4, 2019


This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
+ Coverage   98.18%   98.19%   +0.01%     
  Files           5        5              
  Lines         220      222       +2     
+ Hits          216      218       +2     
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/CoreXLSX.swift 97.64% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb81c12...e505c36. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit 19975bc into master Feb 5, 2019

4 checks passed

codecov/patch 100% of diff hit (target 98.18%)
codecov/project 98.19% (+0.01%) compared to fb81c12
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

0.4 release automation moved this from Reviewer approved to Done Feb 5, 2019

@delete-merged-branch delete-merged-branch bot deleted the error-context branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.