Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SharedStrings model, parse sharedStrings.xml #8

Merged
merged 4 commits into from Dec 3, 2018

Conversation

Projects
None yet
1 participant
@MaxDesiatov
Copy link
Owner

commented Nov 18, 2018

As reported in #21, there's no obvious way to get values for some values. That's caused by the fact that some of the values are stored in a separate file, which is usually located at the path sharedStrings.xml. This can be parsed to a corresponding model type and then processed by users of CoreXLSX to get the string values.

@codecov

This comment has been minimized.

Copy link

commented Nov 18, 2018

Codecov Report

Merging #8 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   98.07%   98.11%   +0.03%     
==========================================
  Files           5        5              
  Lines         208      212       +4     
==========================================
+ Hits          204      208       +4     
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/Worksheet/Worksheet.swift 100% <ø> (ø) ⬆️
Sources/CoreXLSX/CoreXLSX.swift 97.33% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd48966...33e1c8e. Read the comment docs.

MaxDesiatov added some commits Nov 18, 2018

@MaxDesiatov MaxDesiatov force-pushed the shared-strings branch from eedc3ea to d0e0abf Nov 30, 2018

@MaxDesiatov MaxDesiatov merged commit bffbcd8 into master Dec 3, 2018

4 checks passed

codecov/patch 100% of diff hit (target 98.07%)
Details
codecov/project 98.11% (+0.03%) compared to bd48966
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the shared-strings branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.