Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint components type #102

Merged
merged 7 commits into from May 30, 2019

Conversation

@hodovani
Copy link
Collaborator

commented May 30, 2019

No description provided.

hodovani added some commits May 30, 2019


class LedZeppelinLeaf: PureLeafComponent {
let doIhaveToGo = false
enum whatMakeMe: String {

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot May 30, 2019

Type Name Violation: Type name should start with an uppercase character: 'whatMakeMe' (type_name)


class LedZeppelinLeaf: PureLeafComponent {
let doIhaveToGo = false
enum whatMakeMe: String {

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot May 30, 2019

Type Name Violation: Type name should start with an uppercase character: 'whatMakeMe' (type_name)

@codecov

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #102 into master will increase coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   54.59%   55.25%   +0.66%     
==========================================
  Files          77       78       +1     
  Lines        1480     1502      +22     
==========================================
+ Hits          808      830      +22     
  Misses        672      672
Impacted Files Coverage Δ
Sources/TokamakLint/Rules/HooksRule.swift 98.63% <100%> (ø) ⬆️
...rces/TokamakLint/Rules/ComponentIsStructRule.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30a2b9d...088c220. Read the comment docs.

hodovani added some commits May 30, 2019

@hodovani hodovani requested a review from MaxDesiatov May 30, 2019

@hodovani hodovani merged commit 770e1c4 into master May 30, 2019

4 checks passed

Hound No violations found. Woof!
MaxDesiatov.Tokamak Build #20190530.9 succeeded
Details
codecov/patch 100% of diff hit (target 54.59%)
Details
codecov/project 55.25% (+0.66%) compared to 30a2b9d
Details

@delete-merged-branch delete-merged-branch bot deleted the lint/components-type branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.