Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TokamakLogger #104

Merged
merged 20 commits into from Jun 4, 2019

Conversation

@hodovani
Copy link
Collaborator

commented Jun 1, 2019

No description provided.

hodovani added some commits Jun 1, 2019

Merge branch 'master' into swift-log
# Conflicts:
#	Tokamak.xcodeproj/project.pbxproj
}
}

public func log(

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Jun 1, 2019

Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)

@codecov

This comment has been minimized.

Copy link

commented Jun 1, 2019

Codecov Report

Merging #104 into master will increase coverage by 0.11%.
The diff coverage is 49.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   55.25%   55.37%   +0.11%     
==========================================
  Files          78       79       +1     
  Lines        1502     1544      +42     
==========================================
+ Hits          830      855      +25     
- Misses        672      689      +17
Impacted Files Coverage Δ
Sources/TokamakLint/Models/TokamakLint.swift 0% <0%> (ø) ⬆️
Sources/TokamakLint/Reporters/XcodeReporter.swift 0% <0%> (ø) ⬆️
...rces/TokamakLint/Reporters/TokamakLogHandler.swift 59.52% <59.52%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cdb198...4b7499e. Read the comment docs.

hodovani added some commits Jun 1, 2019

hodovani added some commits Jun 2, 2019

@hodovani hodovani marked this pull request as ready for review Jun 3, 2019

@MaxDesiatov
Copy link
Owner

left a comment

LGTM, the only nitpick is that now errors can be merged into a single enum

hodovani added some commits Jun 4, 2019

import Foundation
import Logging

enum TokamakLintError: Error {

This comment has been minimized.

Copy link
@MaxDesiatov

MaxDesiatov Jun 4, 2019

Owner

please make it public, so that end users are able to catch this error

@hodovani hodovani merged commit d0016c3 into master Jun 4, 2019

2 of 4 checks passed

Hound 1 violation found.
codecov/patch 49.01% of diff hit (target 55.25%)
Details
MaxDesiatov.Tokamak Build #20190604.5 succeeded
Details
codecov/project 55.37% (+0.11%) compared to 8cdb198
Details

@delete-merged-branch delete-merged-branch bot deleted the swift-log branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.