New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added complex tests #11

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@shnhrrsn
Contributor

shnhrrsn commented Nov 19, 2016

I added a few complex tests:

foo.bar.hoge("poge")[1].bar.isNil
foo.bar["hoge"]["poge"].foo[bar][2].isNil
(hoge.poge || { }).foo.bar["hoge"][3].poge.isNil

The tests are failing as the compiled output is:

_isNilWrapper(foo.bar.hoge.bar)
_isNilWrapper(foo.bar.foo.bar[2])
_isNilWrapper(hoge.poge.foo.bar.poge)

When they should be:

_isNilWrapper(foo.bar.hoge("poge")[1].bar)
_isNilWrapper(foo.bar["hoge"]["poge"].foo[bar][2])
_isNilWrapper((hoge.poge || { }).foo.bar[3]["hoge"].poge)

I don‘t know how to fix these myself, but these scenarios should compile to the original code.

@shnhrrsn shnhrrsn changed the title from Added complex test to Added complex tests Nov 19, 2016

@MaxMEllon

This comment has been minimized.

Show comment
Hide comment
@MaxMEllon

MaxMEllon Nov 19, 2016

Owner

Thank you PR.

humm... I attempt fixed.

Owner

MaxMEllon commented Nov 19, 2016

Thank you PR.

humm... I attempt fixed.

@shnhrrsn shnhrrsn referenced this pull request Oct 11, 2017

Merged

Improvements #13

@shnhrrsn shnhrrsn closed this Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment