New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot print underlined text #1288

Closed
agross opened this Issue Oct 17, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@agross
Copy link

agross commented Oct 17, 2017

Versions

ConEmu build: 170910 x64
OS version: Windows 10 x64
Used shell version : bash 4.4.12(3)-release (x86_64-unknown-cygwin), 4.4.12(1)-release (x86_64-pc-msys)

Problem description

Underlined text is displayed as standout text.

Steps to reproduce

  1. Install Cygwin, MSYS2/MinGW and ConEmu
  2. Launch ConEmu, let ConEmu detect tasks
  3. Open Bash | CygWin Bash
  4. Execute printf '\e[31;1;4mboldredunderlined\e[0m \e[1;4mboldunderlined\e[0m \e[4munderlined\e[0m\n'
  5. Repeat 3 and 4 with Bash | Msys2-64

Actual results

  1. Cygwin Bash:

cygwin

  1. MSYS Bash:

msys

Expected results

iterm

Maximus5 added a commit that referenced this issue Oct 20, 2017

gh-1288: Use ANSI to underline text.
  Since now, ambiguous sequences like `ESC[1m`, `ESC[3m`, `ESC[4m`, `ESC[5m`
  are not used to increase the brightness of background/foreground colors,
  instead they are used to set ‘bold’, ‘inverse’ and ‘underline’ attributes.
  To set bright text or background colors one may use sequences `ESC [ 90…97 m`
  or `ESC [ 100…107 m` accordingly.
@ecx86

This comment has been minimized.

Copy link

ecx86 commented Oct 26, 2017

I've noticed this for a long time but never got around to making an issue. Thanks!

@agross

This comment has been minimized.

Copy link

agross commented Oct 28, 2017

Seems to be fixed in 171025 😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment