New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fails silently if 7zip isn't found #1338

Closed
rlabrecque opened this Issue Nov 28, 2017 · 2 comments

Comments

Projects
3 participants
@rlabrecque

rlabrecque commented Nov 28, 2017

Versions

ConEmu build: 170910 x64
OS version: Windows 10 1703 x64
Used shell version (Far Manager, git-bash, cmd, powershell, cygwin, whatever): N/A

Problem description

If the 7-Zip archive (ConEmu.7z), WinRar or 7-Zip required field doesn't point to a valid file then Apply & Check fails silently without an error.
https://i.imgur.com/2tdC34y.png

I didn't see this get fixed since 170910 but I can't really test it anymore. I installed 7-Zip to update ConEmu and it worked as expected after doing that! :)

@Maximus5 Maximus5 added this to To Do in ConEmu Dec 27, 2017

@Maximus5 Maximus5 moved this from To Do to In progress in ConEmu Jan 30, 2018

@Maximus5 Maximus5 moved this from In progress to Ready for Testing in ConEmu Feb 6, 2018

@dogancelik

This comment has been minimized.

dogancelik commented Apr 18, 2018

@Maximus5 Is it possible to ship 7-zip executable or integrate its library (7za) with ConEmu?

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Apr 18, 2018

No and no.

  1. If you downloaded 7z package and were able to unpack it, that means you already have 7-zip on your computer.
  2. Even if I ship 7za within ConEmu it will not be able to unpack newer 7-zip format when it changes at some moment.
  3. I don't like the idea of having a megabyte of code in ConEmu (as library) just for unpacking. And the same note about format change.

If one don't want to install 7-zip, they may use installer which does not require any third-party software.

The original issue is resolved.

@Maximus5 Maximus5 closed this Apr 18, 2018

ConEmu automation moved this from Ready for Testing to Done Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment