Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
minor nuisance about background image rendering, and some ideas #1372
ConEmu build: 171217 alpha x64
a background image will not fill the entire window area, but only the text area, when the window size is not integral multiple of the font size. normally when the window is resized, the font size is checked and respected, but in some case it can happen that the text area is not the same as the window's client area, as described below
although it is not really a functional bug, it might be a little bit annoying for OCD users like me.
this issue is related with font sizes and can be most obviously seen using large font sizes.
Steps to reproduce
there are at least 2 methods to demostrate this:
I discovered this because my laptop screen is 1366 pixel wide, and I want to set the font size to 16, then I notice the gap.
after hours of digging into the code, I found the function
imo it'd be better to use the window size instead of the text rect. this way, we can also draw the background image under the status bar area, preferablly with smaller alpha value to blend with the color pallete.
unfortunately, I am not able to understand the whole codebase and don't have visual studio installed to test it out myself.
btw, I'd like to also suggest to draw a single background image for splitted panes. currently, it looks like screenshot 3, which looks, in my option, not very good. but this might need to change the way how the background coordiates are calculated.
again, I can't test it myself. sorry about that.
the issue of missing background image on the border around the textarea is fixed in release 171226.
still looking forward to the feature of drawing background on statusbar, and drawing a single background image for split panes.