New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerline prompt has extra space between prompt and cursor #1501

Open
kerol2r20 opened this Issue Apr 3, 2018 · 15 comments

Comments

3 participants
@kerol2r20

kerol2r20 commented Apr 3, 2018

I found that there are extra spaces when I use Powerline theme.

Environment:
Windows 10 1709
Powershell with posh-git and oh-my-posh modules.

I have tried many release versions of ConEmu. And I found that this bug dose not appear in the earlier version.
The key version between this bug occur is 170402 and 170517.
Until now, this bug has still existed in the latest version.

The following is a screenshot.

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Apr 4, 2018

Really? A year old build?

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Apr 4, 2018

What exact "latest" version have you checked?

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Apr 4, 2018

I need Log Files and ANSI output with repro

@Maximus5 Maximus5 added the drawing-cjk label Apr 4, 2018

@kerol2r20

This comment has been minimized.

kerol2r20 commented Apr 5, 2018

I have tried the latest release version 180318, but there is still the same bug.
The following is my log and ANSI output files.
Logs

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Apr 6, 2018

Please run from ConEmu prompt ConEmuC -CheckUnicode and push screenshot here

@kerol2r20

This comment has been minimized.

kerol2r20 commented Apr 6, 2018

Version 170402:

Version 170517:

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Apr 6, 2018

I'm interested in output from latest 180318 build

@kerol2r20

This comment has been minimized.

kerol2r20 commented Apr 6, 2018

The following is screenshot of 180318 build.

@Maximus5 Maximus5 added this to To Do in Inspection via automation Apr 6, 2018

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Apr 8, 2018

Please download fresh build 180408 and show output of ConEmuC -CheckUnicode again.

@kerol2r20

This comment has been minimized.

kerol2r20 commented Apr 8, 2018

Screenshot

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Apr 8, 2018

I wonder, are there any changes with this patch?

@Maximus5

This comment has been minimized.

Maximus5 added a commit that referenced this issue Apr 8, 2018

gh-1501: Try to fix cursor position after Powerline prompt on CJK Win…
…dows 10.

  Windows 10 CJK version set COMMON_LVB_*_BYTE even for SOME non-ASCII characters:
  e.g. Greek "Α", Russian "Я", etc.
@kerol2r20

This comment has been minimized.

kerol2r20 commented Apr 9, 2018

It looks good~

@Maximus5 Maximus5 removed this from To Do in Inspection Apr 9, 2018

@Maximus5 Maximus5 added this to To Do in ConEmu via automation Apr 9, 2018

@Maximus5 Maximus5 moved this from To Do to Ready for Testing in ConEmu Apr 9, 2018

@ii1liill

This comment has been minimized.

ii1liill commented Aug 17, 2018

This update works nice for me too! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment