New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git hangs when Inject ConEmuHk.dll option is enabled #1510

Closed
lpatalas opened this Issue Apr 12, 2018 · 8 comments

Comments

Projects
9 participants
@lpatalas

lpatalas commented Apr 12, 2018

Versions

ConEmu build: 180411 x64
OS version: Windows 10 Pro x64
Used shell version: Powershell 5.1.16299.251
Git version: 2.16.2.windows.1

Problem description

Some Git commands hang when Inject ConEmuHk.dll into all processes started in ConEmu tabs is checked in general settings. These are for example: git status --short and git branch. They sometimes can be killed with Ctrl+C but sometimes not - it seems kinda random.

What's interesting is that git status (without --short) works inside repository, but when run outside of any Git repository it also hangs.

Steps to reproduce

  1. Enable Inject ConEmuHk.dll into all processes started in ConEmu tabs setting.
  2. Run git status --short

Actual results

The command hangs.

Expected results

The command should not hang.

@Maximus5 Maximus5 added this to To Do in Inspection via automation Apr 12, 2018

@Maximus5 Maximus5 added the hooks label Apr 12, 2018

@lpatalas

This comment has been minimized.

lpatalas commented Apr 12, 2018

One additional info: I just checked and it works in previous build 180409.

@cdonnellytx

This comment has been minimized.

cdonnellytx commented Apr 12, 2018

I am seeing the same problem with git on build 180411 x64. I've confirmed it also happens for git 2.14.3 and git 2.17.0-rc1 (Chocolatey "git 2.17.0").

When in a valid repository, git push and git checkout -b foobar hang for me.

Update: Downgrading to 180409 also fixed it for me. Link (portable) for those who want to downgrade.

@hutnikau

This comment has been minimized.

hutnikau commented Apr 13, 2018

The same issue on 180411 x64 (git version 2.10.1)

@kmiasko

This comment has been minimized.

kmiasko commented Apr 13, 2018

Eh... Same on 180411 x64 (git version 2.17.0.windows.1)

@bitleader

This comment has been minimized.

bitleader commented Apr 13, 2018

Same on 180411 x64 (git version 2.16.2.windows.1)

@theficus

This comment has been minimized.

theficus commented Apr 13, 2018

Also on 180411 here. It's not 100% consistent, but it does happen quite often. I tried on several versions of git -- 2.14, and 2.16. This did not happen on earlier builds. Commands like git pull, git push, git checkout can all hang. This does not happen in a regular cmd.exe window.

Disabling conemuhk.dll injection seems to work around this.

@cheoAlejo

This comment has been minimized.

cheoAlejo commented Apr 13, 2018

Same problem here. Previous version was working fine.

@Maximus5 Maximus5 removed this from To Do in Inspection Apr 15, 2018

@Maximus5 Maximus5 added this to To Do in ConEmu via automation Apr 15, 2018

@Maximus5 Maximus5 moved this from To Do to In progress in ConEmu Apr 15, 2018

@Maximus5 Maximus5 moved this from In progress to Ready for Testing in ConEmu Apr 15, 2018

@lll000111

This comment has been minimized.

lll000111 commented Apr 16, 2018

The new version now works for me.

@Maximus5 Maximus5 closed this Apr 16, 2018

ConEmu automation moved this from Ready for Testing to Done Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment