Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to select text with mouse #1534

Closed
dakotahawkins opened this issue Apr 28, 2018 · 22 comments
Closed

Unable to select text with mouse #1534

dakotahawkins opened this issue Apr 28, 2018 · 22 comments
Projects

Comments

@dakotahawkins
Copy link

@dakotahawkins dakotahawkins commented Apr 28, 2018

Versions

ConEmu build: 180427 x64
OS version: Windows 10 x64
Used shell version: git-bash, cmd, powershell

Problem description

Left click does nothing

Steps to reproduce

  1. Try to left click and drag to select/copy some text
  2. Fail

Actual results

Nothing happens

Expected results

Can select and copy text

Additional files

Settings screenshot

Settings xml

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Apr 28, 2018

Nope. Selection is working on your config.

2018-04-28_21-34-53

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 28, 2018

@Maximus5 That's good, then. Thanks for testing it!

It still doesn't mark at all for me (though I can right click the tab and use edit > mark text) to do it, so maybe something is weird with my environment.

I notice now it's also broken if I just run cmd.exe outside of ConEmu... I see that QuickEdit Mode is disabled there for some reason:
image

Fixing that setting in cmd.exe / sh.exe doesn't affect ConEmu. I'll try restarting my machine and report back in a few minutes.

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 28, 2018

Still not working. I'm not sure what to try.

Edit: I will see if I can build/debug.

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Apr 28, 2018

I don't know what are you doing. The selection just works.

And if course properties of RealConsole have no effect on selection in ConEmu.

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 28, 2018

I'm doing what you are doing in your animation, except there's no selection.

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Apr 28, 2018

Show your animation

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 28, 2018

Used ScreenToGif and turned on "detect mouse clicks" option:

conemu

@maddin77
Copy link

@maddin77 maddin77 commented Apr 28, 2018

I have the same problem. Downgrading to 18.4.22.0 via chocolatey fixed this for me.

@agross
Copy link

@agross agross commented Apr 28, 2018

I also have the same problem. Mouse (left) does neither select nor paste with right-click.

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Apr 28, 2018

  1. Run ConEmu64.exe -basic -log -run cmd. Does section works?
  2. Run ConEmu64.exe -log -run cmd /D. She question.
    Upload LogFiles on problems.

@dakotahawkins there is blinking on your screenshot, may this depict up/down/up/down mouse events?

@agross
Copy link

@agross agross commented Apr 28, 2018

Run ConEmu64.exe -basic -log -run cmd. Does section works?

That works.

Run ConEmu64.exe -log -run cmd /D. She question.

ConEmu-con-22196.log
ConEmu-gui-9872.log
ConEmu-srv-22196.log

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 28, 2018

@Maximus5 I don't think so, I think it's probably an artifact of the capture program I used. Or do you mean the insert cursor blinking? It's just configured to blink, I think.

Run ConEmu64.exe -basic -log -run cmd. Does section works?

Also works for me

Run ConEmu64.exe -log -run cmd /D

Doesn't work.

Logs from second command:

ConEmu-con-13596.log
ConEmu-gui-8724.log
ConEmu-srv-13596.log

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 28, 2018

I can reproduce the issue in a debug build with my settings (but it doesn't reproduce with the default settings!).

Is there anything you'd like me to look at?

@suksit
Copy link

@suksit suksit commented Apr 29, 2018

I also got this problem. I tried resetting the options and re-configured ConEmu step-by-step and I believe the culprit is the Scrollbar settings -- if you set Scrollbar to "Show" then you'll get this behavior.

options

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 29, 2018

Confirmed! -- Mine was set to "Show" and setting it to "Auto" instead lets me select with my mouse.

Makes sense as some of the changes between the previous version and this one related to auto-showing the scrollbar.

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 29, 2018

It's because of this.

bool CConEmuChild::CheckMouseOverScroll() always returns true if the scrollbar is always visible -- regardless of whether the mouse is actually over it.

Trying a few things now to see if I can adjust the logic and preserve the fix for the bug that was intended to fix.

dakotahawkins added a commit to dakotahawkins/ConEmu that referenced this issue Apr 29, 2018
… bar show set to "Always"
@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 29, 2018

As I mentioned in the diff for #1536, there are usages of CConEmuChild::CheckMouseOverScroll() that might expect different results for different reasons, so I'm not positive that doesn't break anything else.

Regardless, I think it should never return true without checking, and in debug that change fixed this issue and hovering over the scroll area displayed the scrollbar as expected when scrollbar visibility was set to "Auto".

@alexdevero
Copy link

@alexdevero alexdevero commented Apr 29, 2018

The same issue:
ConEmu build: 180427 x64
OS version: Windows 10 x64
Used shell version: cmd

As @dakotahawkins and @suksit mentioned, switching Scrollbar form "Show" to "Auto" allows text selection with mouse.

@Maximus5 Maximus5 added this to To Do in ConEmu via automation Apr 29, 2018
@Maximus5 Maximus5 moved this from To Do to Ready for Testing in ConEmu Apr 29, 2018
@DJviolin
Copy link

@DJviolin DJviolin commented Apr 30, 2018

Same issue here from the last alpha update:

OS verison: Windows 10 10.0.16299.402
Conemu version: 180427 preview

Setting the scrollbar to auto also solving this for me, temporarily.

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Apr 30, 2018

It was fixed in 180429, kudos to @dakotahawkins

@refack
Copy link

@refack refack commented Apr 30, 2018

Confirmed was broken and now fixed here as well. Thanks all.
Microsoft Windows [Version 10.0.17655.1000]

@dakotahawkins
Copy link
Author

@dakotahawkins dakotahawkins commented Apr 30, 2018

It's working great for me on a Win10 machine and a Win7 machine.

I'll go ahead and close this since the fix is available in the new install.

ConEmu automation moved this from Ready for Testing to Done Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ConEmu
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

8 participants