Bang/Exclamation mark (!) not escaped when pasting paths

[damisan]

Versions

ConEmu build: 180506 x32/x64
OS version: Windows 7 x64
Used shell version: msys2

Problem description

Bangs in paths are not escaped on Windows to POSIX conversion (drag-and-drop, pasete, ...)

Steps to reproduce

A

1. Copy path to clipboard "c:\folder!bang" (without quotes)
2. Paste into ConEmu (right mouse click)

B

1. Create folder c:\folder!bang
2. Drag-and-drop the folder to ConEmu

Actual results

/c/folder!bang
(missing \ before !)

Expected results

/c/folder\!bang

[damisan]

It seems to be enough to add ! to the else part in posixSpec (ConEmuApp.cpp line 649)
const wchar_t* posixSpec = bAutoQuote ? L"$" : L" ()$!";

[Maximus5]

Almost. It should be

const wchar_t* posixSpec = bAutoQuote ? L"$!" : L" ()$!";

[damisan]

Escaping ! in quoted string doesn't work in mingw/bash

# Double quoted, escaped with \
$ cd "c:\folder with space\spaces and bang \!\! bang"
bash: cd: c:\folder with space\spaces and bang \!\! bang: No such file or directory

# Single quoted, escaped with \
$ cd 'c:\folder with space\spaces and bang \!\! bang'
bash: cd: c:\folder with space\spaces and bang \!\! bang: No such file or directory

# Double quoted, unescaped
$ cd "c:\folder with space\spaces and bang !! bang"
# WRONG: some command history magic happening

# Single quoted, unescaped
$ cd 'c:\folder with space\spaces and bang !! bang'
# OK

# Unquoted, \-escapd
$ cd /c/folder\ with\ space/spaces\ and\ bang\ \!\!\ bang
# OK, but looks ugly compared to the single quoted, unescaped

# Double quoted + single quoted !
$ cd "c:\folder with space\spaces and bang "'!!'" bang"
# OK

So autoQuoting should be done with single quotes to avoid "'!'" quoting.

But I found now way to enable pasting/d'n'd-ing quoted paths, thus I was unable to test it.
Moreover: I would just prefer POSIX path conversion to produce quoted string (only when needed) if favor of escaping every single space etc.

[damisan]

In what version of mingw/bash?

The most recent one

$ bash --version
GNU bash, version 4.4.19(2)-release (x86_64-pc-msys)

In what version in actually does work?

[Maximus5]

Reading about quoting: http://wiki.bash-hackers.org/syntax/quoting

Consider following changes:

• DupCygwinPath would be called with bAutoQuote=true on Paste; it would be still possible to paste with bAutoQuote=false via GuiMacro
• Use strong quoting (single-quote) where only ' have to be weirdly-quoted: 'Here'\''s my test...'