Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme scroll bars #1733

Closed
musm opened this issue Oct 11, 2018 · 21 comments
Closed

Dark theme scroll bars #1733

musm opened this issue Oct 11, 2018 · 21 comments
Labels
Projects
Milestone

Comments

@musm
Copy link

@musm musm commented Oct 11, 2018

See microsoft/terminal#277

thanks

@Maximus5 Maximus5 added this to To Do in ConEmu via automation Oct 12, 2018
@Maximus5 Maximus5 added this to To Do in Drawing via automation Oct 12, 2018
@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Oct 12, 2018

Actually, I have intention to make scrollbars drawn internally. But till it is not implemented, I can try API way.

@musm
Copy link
Author

@musm musm commented Oct 12, 2018

see the suggestion here microsoft/terminal#277 (comment)

@musm
Copy link
Author

@musm musm commented Oct 29, 2018

Can you try to set
SetWindowTheme(GetConsoleWindow(), L"DarkMode_Explorer", nullptr); ?

@musm
Copy link
Author

@musm musm commented Jan 16, 2019

friendly bump 😄

@Maximus5 Maximus5 added this to the 190304 milestone Mar 3, 2019
@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 10, 2019

2019-03-10_21-49-42

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 10, 2019

190310

@Maximus5 Maximus5 removed this from To Do in ConEmu Mar 10, 2019
@Maximus5 Maximus5 moved this from To Do to Ready for Testing in Drawing Mar 10, 2019
@musm
Copy link
Author

@musm musm commented Mar 11, 2019

so awesome, thanks mate

@musm
Copy link
Author

@musm musm commented Mar 11, 2019

Is there a way to enable this for conemu shell integration?

@seritools
Copy link

@seritools seritools commented Mar 11, 2019

Yup, would be good to just have it as a toggle in the settings menu.

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 11, 2019

Yup, would be good to just have it as a toggle in the settings menu.

There are too many options and toggles.

Is there a way to enable this for conemu shell integration?

Of course. Integration docs for Command field
Example: -Theme -run {powershell} -cur_console:n

2019-03-12_00-29-26

@musm
Copy link
Author

@musm musm commented Mar 11, 2019

Thanks,

what about for Startup - Tasks ?

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 11, 2019

@musm Do you mean taskbar jump lists? If not, you may just modify shortcut properties.

@musm
Copy link
Author

@musm musm commented Mar 11, 2019

No, I mean
jumplist tasks
image

I can't get these to use the new dark theme bar

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 12, 2019

Jump lists are tricky 🙄

Add -theme in Task parameters.
Go to the "Task bar" settings page and update jump lists, disable "auto update" if it's enabled.
Return to "Tasks" page, remove "-theme" from parameters.
Save settings

@musm
Copy link
Author

@musm musm commented Mar 12, 2019

works 👍 , but yes indeed tricky

@seritools
Copy link

@seritools seritools commented Mar 13, 2019

There are too many options and toggles.

I mean I'd prefer a setting rather than adding -Theme everywhere, but I guess that works as well.

@seritools
Copy link

@seritools seritools commented Mar 13, 2019

Oh, maybe checking if dark mode is enabled in the system could work too?

https://stackoverflow.com/questions/51334674/how-to-detect-windows-10-light-dark-mode-in-win32-application

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 13, 2019

Good point, I'll check it

@Maximus5 Maximus5 modified the milestones: 190304, 190311 Mar 13, 2019
@ysc3839
Copy link

@ysc3839 ysc3839 commented Mar 14, 2019

https://github.com/ysc3839/win32-darkmode
Here is a program shows how to use undocumented dark mode API.

@Maximus5 Maximus5 modified the milestones: 190311, 190318 Mar 24, 2019
@Maximus5 Maximus5 modified the milestones: 190325, 190401 Mar 31, 2019
@silverqx
Copy link

@silverqx silverqx commented Jun 24, 2019

dark scrollbars are amazing thx

@silverqx
Copy link

@silverqx silverqx commented Jun 25, 2019

Dark scrollbars doesn't work when I select auto hide scrollbar, my fault, works as expected, I didn't have '-Theme' parameter in start menu shortcut ( lnk ) file

@Maximus5 Maximus5 closed this Sep 21, 2019
Drawing automation moved this from Ready for Testing to Done Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Drawing
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants