Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme scroll bars #1733

Open
musm opened this Issue Oct 11, 2018 · 19 comments

Comments

4 participants
@musm
Copy link

musm commented Oct 11, 2018

@Maximus5 Maximus5 added the drawing label Oct 12, 2018

@Maximus5 Maximus5 added this to To Do in ConEmu via automation Oct 12, 2018

@Maximus5 Maximus5 added this to To Do in Drawing via automation Oct 12, 2018

@Maximus5

This comment has been minimized.

Copy link
Owner

Maximus5 commented Oct 12, 2018

Actually, I have intention to make scrollbars drawn internally. But till it is not implemented, I can try API way.

@musm

This comment has been minimized.

Copy link
Author

musm commented Oct 12, 2018

see the suggestion here Microsoft/console#277 (comment)

@musm

This comment has been minimized.

Copy link
Author

musm commented Oct 29, 2018

Can you try to set
SetWindowTheme(GetConsoleWindow(), L"DarkMode_Explorer", nullptr); ?

@musm

This comment has been minimized.

Copy link
Author

musm commented Jan 16, 2019

friendly bump 😄

@Maximus5 Maximus5 added this to the 190304 milestone Mar 3, 2019

@Maximus5

This comment has been minimized.

Copy link
Owner

Maximus5 commented Mar 10, 2019

2019-03-10_21-49-42

@Maximus5

This comment has been minimized.

Copy link
Owner

Maximus5 commented Mar 10, 2019

190310

@Maximus5 Maximus5 removed this from To Do in ConEmu Mar 10, 2019

@Maximus5 Maximus5 moved this from To Do to Ready for Testing in Drawing Mar 10, 2019

@musm

This comment has been minimized.

Copy link
Author

musm commented Mar 11, 2019

so awesome, thanks mate

@musm

This comment has been minimized.

Copy link
Author

musm commented Mar 11, 2019

Is there a way to enable this for conemu shell integration?

@seritools

This comment has been minimized.

Copy link

seritools commented Mar 11, 2019

Yup, would be good to just have it as a toggle in the settings menu.

DanaMW added a commit to DanaMW/ConEmu that referenced this issue Mar 11, 2019

Merge remote-tracking branch 'upstream/master'
* upstream/master: (22 commits)
  190310 release files
  Internal. Release and deply scripts
  190310 Chocolatey and Nuget
  Internal. Release and deploy scripts
  ANSI: Visual Bell for `ESC g`.
  Maximus5gh-1733: Enable dark theme scrollbars with `ConEmu.exe -Theme DarkMode_Explorer`.
  Log duration of external hooks checks.
  Internal. MPerfCounter improvements
  Maximus5gh-463: ConEmu.exe switch `-NoHooksWarn` disabled external hooks checks.
  Internal. Ignore PVS-Studio generated files
  Internal. Log ms for RefillConsoleAttributes
  Connector: When `--log` is used, log current system time each 500ms.
  Maximus5gh-1323, Maximus5gh-1385, Maximus5gh-1841: Let ‘Alternative mode’ toolbar button works with console buffers.
  Internal. Log timeouted LoadAlternativeConsole
  Internal. Fix pvs warnings
  Maximus5gh-1323, Maximus5gh-1385, Maximus5gh-1841: Speed up alternative buffer operations (connector).
  Internal. Fix some cl warnings (type cast)
  Internal. IsWin7Eql
  Internal. Remove unused/commented code
  Internal. Preparation for strikethrough
  ...
@Maximus5

This comment has been minimized.

Copy link
Owner

Maximus5 commented Mar 11, 2019

Yup, would be good to just have it as a toggle in the settings menu.

There are too many options and toggles.

Is there a way to enable this for conemu shell integration?

Of course. Integration docs for Command field
Example: -Theme -run {powershell} -cur_console:n

2019-03-12_00-29-26

@musm

This comment has been minimized.

Copy link
Author

musm commented Mar 11, 2019

Thanks,

what about for Startup - Tasks ?

@Maximus5

This comment has been minimized.

Copy link
Owner

Maximus5 commented Mar 11, 2019

@musm Do you mean taskbar jump lists? If not, you may just modify shortcut properties.

@musm

This comment has been minimized.

Copy link
Author

musm commented Mar 11, 2019

No, I mean
jumplist tasks
image

I can't get these to use the new dark theme bar

@Maximus5

This comment has been minimized.

Copy link
Owner

Maximus5 commented Mar 12, 2019

Jump lists are tricky 🙄

Add -theme in Task parameters.
Go to the "Task bar" settings page and update jump lists, disable "auto update" if it's enabled.
Return to "Tasks" page, remove "-theme" from parameters.
Save settings

@musm

This comment has been minimized.

Copy link
Author

musm commented Mar 12, 2019

works 👍 , but yes indeed tricky

@seritools

This comment has been minimized.

Copy link

seritools commented Mar 13, 2019

There are too many options and toggles.

I mean I'd prefer a setting rather than adding -Theme everywhere, but I guess that works as well.

@seritools

This comment has been minimized.

Copy link

seritools commented Mar 13, 2019

Oh, maybe checking if dark mode is enabled in the system could work too?

https://stackoverflow.com/questions/51334674/how-to-detect-windows-10-light-dark-mode-in-win32-application

@Maximus5

This comment has been minimized.

Copy link
Owner

Maximus5 commented Mar 13, 2019

Good point, I'll check it

@Maximus5 Maximus5 modified the milestones: 190304, 190311 Mar 13, 2019

@ysc3839

This comment has been minimized.

Copy link

ysc3839 commented Mar 14, 2019

https://github.com/ysc3839/win32-darkmode
Here is a program shows how to use undocumented dark mode API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.