Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConEmu becomes visible when external monitor is plugged/unplugged #1795

Open
brunoschmidt opened this Issue Jan 2, 2019 · 3 comments

Comments

Projects
2 participants
@brunoschmidt
Copy link

brunoschmidt commented Jan 2, 2019

Versions

ConEmu build: 180626 x64
OS version: Windows 10 1809 17763.195 x64
Computer: Lenovo Thinkpad T580
Used shell version (Far Manager, git-bash, cmd, powershell, cygwin, whatever): WSL, git-bash, cmd

Problem description

Every time I plug/unplug an external monitor to my laptop, ConEmu becomes visible covering everything else.
Even if there are no tabs opened.

Steps to reproduce

  1. Run ConEmu in quake style
  2. Hide ConEmu with hotkey <CTRL+`>
  3. Unplug the external monitor; ConEmu became visible
  4. Hide ConEmu with hotkey <CTRL+`>
  5. Plug the external monitor; ConEmu became visible again

Actual results

Every time a monitor is plugged/unplugged ConEmu becomes visible.
At the log files it does ReloadMonitorInfo caused by a WM_DISPLAYCHANGED at 18:25:50 and at 18:26:11. In both cases it does a SetWindowMode with wmMaximized.

Expected results

Since the default monitor, where ConEmu is, is not affected, It should stay hidden.

Additional files

ConEmuLogs.zip
conemu config.zip

@Maximus5 Maximus5 added this to To Do in Inspection via automation Jan 17, 2019

@Maximus5

This comment has been minimized.

Copy link
Owner

Maximus5 commented Jan 17, 2019

I suppose I've found the problem.
Can you build ConEmu yourself or you'll wait for new build?

@brunoschmidt

This comment has been minimized.

Copy link
Author

brunoschmidt commented Jan 17, 2019

I can.
Will give it a try tonight or tomorrow.
Thank you for your attention.

@brunoschmidt

This comment has been minimized.

Copy link
Author

brunoschmidt commented Jan 20, 2019

I suppose I've found the problem.
Can you build ConEmu yourself or you'll wait for new build?

I've built it, but it didn't fixed the problem.

I gave it a try and checked your change.
Looks like there is an if just like the one you fixed a dozen lines above on WM_SETTINGCHANGE.
With you correction applied there too, the problem goes away.

Will try to make a pull request tomorrow, but its probably easier for you to replicate the fix.

brunoschmidt pushed a commit to brunoschmidt/ConEmu that referenced this issue Feb 6, 2019

Maximus5 added a commit that referenced this issue Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.