Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clink no longer works with ConEmu - .dll filenames changed #1860

Closed
wegotourselvesareader opened this issue Mar 16, 2019 · 2 comments
Closed

Clink no longer works with ConEmu - .dll filenames changed #1860

wegotourselvesareader opened this issue Mar 16, 2019 · 2 comments
Projects
Milestone

Comments

@wegotourselvesareader
Copy link

@wegotourselvesareader wegotourselvesareader commented Mar 16, 2019

Versions

ConEmu build: 190310 preview x64
OS version: Windows 10 Pro x64
Used shell version (Far Manager, git-bash, cmd, powershell, cygwin, whatever): Clink

Problem description

Clink now ships with DLL files called clink_x86.dll and clink_x64.dll, but the isUseClink routine in ConEmu's Options.cpp checks for clink_dll_x86.dll and clink_dll_x64.dll.

As a result, if the user tries to enable Clink in ConEmu's Features page, the "Clink was not found [...]" error message is displayed.

If the user renames the two DLL files to match the filenames shown in Options.cpp then the next time ConEmu is launched it throws this error from Clink: "The code execution cannot proceed because clink_x64.dll was not found."

In short, Clink looks for one DLL filename; ConEmu looks for a different DLL filename.

WORKAROUND: Copy both DLL files and rename the copies to clink_dll_x86.dll and clink_dll_x64.dll. Then both ConEmu's and Clink's filename checks are satisfied.

Steps to reproduce

  1. Install ConEmu
  2. Download and extract Clink v1.0.0.a1, following the instructions in ConEmu's Readme.txt to put the extracted files directly in ConEmu's clink folder.
  3. Attempt to enable Clink in ConEmu's Features page.

Actual results

The user cannot enable Clink without any errors.

Expected results

The user should be able to enable Clink without any errors.

@Maximus5 Maximus5 added this to the 190311 milestone Mar 17, 2019
@Maximus5 Maximus5 closed this Mar 17, 2019
Maximus5 pushed a commit that referenced this issue Mar 17, 2019
@Maximus5 Maximus5 reopened this Mar 17, 2019
@Maximus5 Maximus5 added this to To Do in ConEmu via automation Mar 24, 2019
@Maximus5 Maximus5 moved this from To Do to Ready for Testing in ConEmu Mar 24, 2019
@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 25, 2019

Loading

@wegotourselvesareader
Copy link
Author

@wegotourselvesareader wegotourselvesareader commented Mar 25, 2019

Seems to be good. I just tested it on two separate computers, and both allowed me to enable and disable Clink with no errors. Thanks!

Loading

@Maximus5 Maximus5 closed this Mar 25, 2019
ConEmu automation moved this from Ready for Testing to Done Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ConEmu
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants