New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-default icons #376

Closed
SergeyVSB opened this Issue Oct 16, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@SergeyVSB
Contributor

SergeyVSB commented Oct 16, 2015

Add ability to load non default icons by index or by resource name (currently, loads icon at 0)

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Oct 16, 2015

Owner

What?

Owner

Maximus5 commented Oct 16, 2015

What?

@SergeyVSB

This comment has been minimized.

Show comment
Hide comment
@SergeyVSB

SergeyVSB Oct 16, 2015

Contributor

Currently ConEmu loads only first icon from binaries that contains multiple icons. I'll try fix this, also may be try to implement loading icons from shell associations (found TODO comment for that in you source)

Contributor

SergeyVSB commented Oct 16, 2015

Currently ConEmu loads only first icon from binaries that contains multiple icons. I'll try fix this, also may be try to implement loading icons from shell associations (found TODO comment for that in you source)

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Oct 16, 2015

Owner

Still not clear. Where? Show an example.

Owner

Maximus5 commented Oct 16, 2015

Still not clear. Where? Show an example.

@SergeyVSB

This comment has been minimized.

Show comment
Hide comment
@SergeyVSB

SergeyVSB Oct 16, 2015

Contributor

Well, for example.
ConEmu autodetects "Dev 14 command prompt" as task. Best icon for this task is icon 33 from %CommonProgramFiles(x86)%\microsoft shared\MSEnv\VSFileHandler.dll but ConEmu can load only icon 0 from exe and dll files

Contributor

SergeyVSB commented Oct 16, 2015

Well, for example.
ConEmu autodetects "Dev 14 command prompt" as task. Best icon for this task is icon 33 from %CommonProgramFiles(x86)%\microsoft shared\MSEnv\VSFileHandler.dll but ConEmu can load only icon 0 from exe and dll files

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Oct 16, 2015

Owner

CIconList::CreateTabIconInt

Owner

Maximus5 commented Oct 16, 2015

CIconList::CreateTabIconInt

@SergeyVSB

This comment has been minimized.

Show comment
Hide comment
@SergeyVSB

SergeyVSB Oct 16, 2015

Contributor

I've found it. Is use ExtractIconEx(pszLoadFile, 0, &hIconLarge, &hIconSmall, 1)
I'll fix it, but it is my first fork on github, so I still learning doing that right

Contributor

SergeyVSB commented Oct 16, 2015

I've found it. Is use ExtractIconEx(pszLoadFile, 0, &hIconLarge, &hIconSmall, 1)
I'll fix it, but it is my first fork on github, so I still learning doing that right

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Oct 16, 2015

Owner

Just push it (when fixed) to your fork, and than create pull request here.

Owner

Maximus5 commented Oct 16, 2015

Just push it (when fixed) to your fork, and than create pull request here.

@SergeyVSB

This comment has been minimized.

Show comment
Hide comment
@SergeyVSB

SergeyVSB Oct 17, 2015

Contributor

Request created
#378

Contributor

SergeyVSB commented Oct 17, 2015

Request created
#378

@Maximus5 Maximus5 closed this Oct 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment