Non-default icons

[SergeyVSB]

Add ability to load non default icons by index or by resource name (currently, loads icon at 0)

[Maximus5]

What?

[Maximus5]

What?

[SergeyVSB]

Currently ConEmu loads only first icon from binaries that contains multiple icons. I'll try fix this, also may be try to implement loading icons from shell associations (found TODO comment for that in you source)

[SergeyVSB]

Currently ConEmu loads only first icon from binaries that contains multiple icons. I'll try fix this, also may be try to implement loading icons from shell associations (found TODO comment for that in you source)

[Maximus5]

Still not clear. Where? Show an example.

[Maximus5]

Still not clear. Where? Show an example.

[SergeyVSB]

Well, for example.
ConEmu autodetects "Dev 14 command prompt" as task. Best icon for this task is icon 33 from %CommonProgramFiles(x86)%\microsoft shared\MSEnv\VSFileHandler.dll but ConEmu can load only icon 0 from exe and dll files

[SergeyVSB]

Well, for example.
ConEmu autodetects "Dev 14 command prompt" as task. Best icon for this task is icon 33 from %CommonProgramFiles(x86)%\microsoft shared\MSEnv\VSFileHandler.dll but ConEmu can load only icon 0 from exe and dll files

[Maximus5]

CIconList::CreateTabIconInt

[Maximus5]

CIconList::CreateTabIconInt

[SergeyVSB]

I've found it. Is use ExtractIconEx(pszLoadFile, 0, &hIconLarge, &hIconSmall, 1)
I'll fix it, but it is my first fork on github, so I still learning doing that right

[SergeyVSB]

I've found it. Is use ExtractIconEx(pszLoadFile, 0, &hIconLarge, &hIconSmall, 1)
I'll fix it, but it is my first fork on github, so I still learning doing that right

[Maximus5]

Just push it (when fixed) to your fork, and than create pull request here.

[Maximus5]

Just push it (when fixed) to your fork, and than create pull request here.

[SergeyVSB]

Request created
#378

[SergeyVSB]

Request created
#378