New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Keyboard shortcut and menu item for closing Standard In #465

Closed
libliflin opened this Issue Dec 13, 2015 · 13 comments

Comments

Projects
None yet
3 participants
@libliflin

libliflin commented Dec 13, 2015

Hi!

After trying to copy some Go code from a book and wondering what is wrong, I've been reading about a few different problems people have with EOF in windows here, here, here, here, here, and here.

If I squint really hard I can see a potential for ConEmu to close it's child's stdin somehow in code, thus optionally making it kinda sorta like bash's Ctrl+D.

Is this possible?

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Dec 13, 2015

Owner

I'm lost. What's the problem?

Owner

Maximus5 commented Dec 13, 2015

I'm lost. What's the problem?

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Dec 13, 2015

Owner

/cc @techtonik does that relates to your Go question?

Owner

Maximus5 commented Dec 13, 2015

/cc @techtonik does that relates to your Go question?

@techtonik

This comment has been minimized.

Show comment
Hide comment
@techtonik

techtonik Dec 13, 2015

Yes. I believe it is related. The problem is that Go programs do not process Ctrl-D and Ctrl-Z input. I don't think that ConEmu should process it, because different programs may have different purposes for that keybinding.

techtonik commented Dec 13, 2015

Yes. I believe it is related. The problem is that Go programs do not process Ctrl-D and Ctrl-Z input. I don't think that ConEmu should process it, because different programs may have different purposes for that keybinding.

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Dec 13, 2015

Owner

Sample Go program?

Owner

Maximus5 commented Dec 13, 2015

Sample Go program?

@techtonik

This comment has been minimized.

Show comment
Hide comment
@techtonik

techtonik Dec 13, 2015

package main

import "fmt"

func main() {
    fmt.Print("Enter text: ")
    var input string
    fmt.Scanln(&input)
    fmt.Print(input)
}

From https://stackoverflow.com/questions/20895552/how-to-read-input-from-console-line

techtonik commented Dec 13, 2015

package main

import "fmt"

func main() {
    fmt.Print("Enter text: ")
    var input string
    fmt.Scanln(&input)
    fmt.Print(input)
}

From https://stackoverflow.com/questions/20895552/how-to-read-input-from-console-line

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Dec 13, 2015

Owner

I don't see any problems with example. It reads one line at a time. Enter stops reading, no additional keypresses (like Ctrl-Z) are required.

Owner

Maximus5 commented Dec 13, 2015

I don't see any problems with example. It reads one line at a time. Enter stops reading, no additional keypresses (like Ctrl-Z) are required.

@techtonik

This comment has been minimized.

Show comment
Hide comment
@techtonik

techtonik Dec 13, 2015

It is just a code to read from input to start from.

techtonik commented Dec 13, 2015

It is just a code to read from input to start from.

@libliflin

This comment has been minimized.

Show comment
Hide comment
@libliflin

libliflin Dec 14, 2015

Hi, No problem, just a feature request. And I don't think this should be part of standard ConEmu. I just think it would be nice for conemu to offer a menu option to close the child's stdin (with the possiblity for a user to bind it to a key binding if they choose)

libliflin commented Dec 14, 2015

Hi, No problem, just a feature request. And I don't think this should be part of standard ConEmu. I just think it would be nice for conemu to offer a menu option to close the child's stdin (with the possiblity for a user to bind it to a key binding if they choose)

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Dec 14, 2015

Owner

@libliflin Unless anyone provides Go example where this feature is required or even helpful - I can't do any test.
Also, I consider this proposal as harmful, because this feature may break further execution of your app.

Owner

Maximus5 commented Dec 14, 2015

@libliflin Unless anyone provides Go example where this feature is required or even helpful - I can't do any test.
Also, I consider this proposal as harmful, because this feature may break further execution of your app.

@libliflin

This comment has been minimized.

Show comment
Hide comment
@libliflin

libliflin commented Dec 14, 2015

The specific code that did not work for me was https://github.com/adonovan/gopl.io/blob/master/ch1/dup2/main.go

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5
Owner

Maximus5 commented Dec 18, 2015

@techtonik

This comment has been minimized.

Show comment
Hide comment

techtonik commented Dec 22, 2015

Go issue golang/go#6303

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5
Owner

Maximus5 commented Dec 22, 2015

OK, 364a769

@Maximus5 Maximus5 closed this Dec 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment