New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress detection doesn't work properly in some programs when your regional settings have "," as the decimal separator #614

Closed
gschizas opened this Issue Mar 30, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@gschizas
Contributor

gschizas commented Mar 30, 2016

To reproduce:

  1. Switch your regional options to some language with "," as a decimal separator (I'm using Greek, but most non-English languages should work)
  2. Use curl (https://curl.haxx.se/download.html) to download any large enough file.
  3. The percentage progress detection stops at the comma, and cycles from 0 to 9% (for 0,0% to 0,9%, 1,0 to 1,9% etc).

Since most programs I've seen won't honor the "," of regional options, the fix should probably be to use "," in addition to the "." as a decimal point.

I've made the change locally (it was a minor change in 3-4 places), but it was some weeks ago and I probably need to do an update before making a pull request.

gschizas added a commit to gschizas/ConEmu that referenced this issue Mar 30, 2016

gh-614: Handle commas as decimal separators
This fixes curl -# -O looping between 0 and 9%

Maximus5 added a commit that referenced this issue Apr 12, 2016

gh-614, gh-616: Handle commas as decimal separators in the in-console…
… progress detection.

  This fixes `curl -# -O` looping between 0 and 9%.

@Maximus5 Maximus5 closed this Apr 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment