New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConEmu Upgrade with Installer: Shows “Installer Failed” for ERROR_SUCCESS_REBOOT_REQUIRED #742

Open
hypersw opened this Issue Jun 20, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@hypersw
Contributor

hypersw commented Jun 20, 2016

A fresh ConEmu build self-updates with an installer, shows a files-in-use prompt, I choose don't reboot, installation completes and the installer returns the ERROR_SUCCESS_REBOOT_REQUIRED code.
ConEmu shows a message box with:

---------------------------
ConEmu 160619 installer
---------------------------
Installer failed
%LOCALAPPDATA%\Temp\ConEmu160619\ConEmu.160619.x64.msi
ExitCode=3010
---------------------------
OK   
---------------------------

This isn't exactly a failure, the installation was OK, and new instances would run OK, but (most likely) there're older consoles which were attached to some ConEmu which has been closed and they fell out, and they're now holding the older copies of the ConEmu DLLs loaded. Unless you try reattaching these windows to the new ConEmu, there'd be no problems. And if you reboot or just close those old windows, that would become a 100% normal installation. So the message might be less frightening, like: “You have chosen not to reboot the machine. Either reboot manually, or close all of the console windows which worked with the previous ConEmu version.”

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Jun 20, 2016

Owner

It's user responsibility to close all ConEmu instances before they run MSI installer. ConEmu tries to detect other instances to warn user, but due to some circumstances it may fail. Anyway, neither MSI nor ConEmu can do "update" if files are locked.

Owner

Maximus5 commented Jun 20, 2016

It's user responsibility to close all ConEmu instances before they run MSI installer. ConEmu tries to detect other instances to warn user, but due to some circumstances it may fail. Anyway, neither MSI nor ConEmu can do "update" if files are locked.

@Maximus5 Maximus5 added the installer label Jun 20, 2016

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Jun 20, 2016

Owner

or close all of the console windows which worked with the previous ConEmu version.

This would not work. Windows update binaries only after reboot.

Owner

Maximus5 commented Jun 20, 2016

or close all of the console windows which worked with the previous ConEmu version.

This would not work. Windows update binaries only after reboot.

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5
Owner

Maximus5 commented Jun 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment