Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Far1 "edit console output" empty output #1063

Conversation

@michaellukashov
Copy link
Contributor

@michaellukashov michaellukashov commented Mar 11, 2017

Problem description:

"Edit console output" shows empty output.

Steps to reproduce:

Run ConEmu with Far1,
Run any console program,
Pick "Plugin commands" -> "ConEmu" --> "Edit console output" command

Actual results

Far1 shows empty editor

Expected results

Far1 editor window with console output.

…utput.

This bug was introduced in rev. dd71baa (Don't run the command started by Shift-Enter from Far Manager via ConEmuC.exe.)
@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 11, 2017

Hm, what conditions are when output is empty in the editor? What is purpose of the patch? Issue?

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 11, 2017

I mean, macro Ctrl+O works for me perfectly.

@michaellukashov
Copy link
Contributor Author

@michaellukashov michaellukashov commented Mar 11, 2017

output is empty on any conditions, with any Far version.
The patch enables viewing and editing of long console output.
Similar issue is mentioned here:
#688 (comment)

@Maximus5
Copy link
Owner

@Maximus5 Maximus5 commented Mar 11, 2017

I don't see the problem: #688 (comment)

@@ -2266,7 +2266,7 @@ int CShellProc::PrepareExecuteParms(
else
{
// хотят GUI прицепить к новой вкладке в ConEmu, или новую консоль из GUI
if (lbGuiApp && (NewConsoleFlags || bForceNewConsole))
if ((bLongConsoleOutput) || (lbGuiApp && (NewConsoleFlags || bForceNewConsole)))

This comment has been minimized.

@Maximus5

Maximus5 Mar 11, 2017
Owner

This is absolutely wrong. The condition checks for starting ChildGui in ConEmu tab, don't change it!

@michaellukashov
Copy link
Contributor Author

@michaellukashov michaellukashov commented Mar 12, 2017

Well, I was wrong, Console output works with Far3, but at least with Far1 "Console output" is empty

conemu-far1

@michaellukashov michaellukashov changed the title Fix far "edit console output" empty output Fix Far1 "edit console output" empty output Mar 12, 2017
@Maximus5 Maximus5 closed this Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants