Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Far1 "edit console output" empty output #1063
Conversation
michaellukashov
added some commits
Mar 11, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Maximus5
Mar 11, 2017
Owner
Hm, what conditions are when output is empty in the editor? What is purpose of the patch? Issue?
|
Hm, what conditions are when output is empty in the editor? What is purpose of the patch? Issue? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I mean, macro Ctrl+O works for me perfectly. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
michaellukashov
Mar 11, 2017
Contributor
output is empty on any conditions, with any Far version.
The patch enables viewing and editing of long console output.
Similar issue is mentioned here:
#688 (comment)
|
output is empty on any conditions, with any Far version. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I don't see the problem: #688 (comment) |
| @@ -2266,7 +2266,7 @@ int CShellProc::PrepareExecuteParms( | ||
| else | ||
| { | ||
| // хотят GUI прицепить к новой вкладке в ConEmu, или новую консоль из GUI | ||
| if (lbGuiApp && (NewConsoleFlags || bForceNewConsole)) | ||
| if ((bLongConsoleOutput) || (lbGuiApp && (NewConsoleFlags || bForceNewConsole))) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Maximus5
Mar 11, 2017
Owner
This is absolutely wrong. The condition checks for starting ChildGui in ConEmu tab, don't change it!
Maximus5
Mar 11, 2017
•
Owner
This is absolutely wrong. The condition checks for starting ChildGui in ConEmu tab, don't change it!
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
michaellukashov
Mar 12, 2017
Contributor
Well, I was wrong, Console output works with Far3, but at least with Far1 "Console output" is empty
|
Well, I was wrong, Console output works with Far3, but at least with Far1 "Console output" is empty
|
michaellukashov
changed the title from
Fix far "edit console output" empty output
to
Fix Far1 "edit console output" empty output
Mar 12, 2017
added a commit
that referenced
this pull request
Mar 15, 2017
Maximus5
closed this
Mar 15, 2017
added a commit
that referenced
this pull request
Apr 2, 2017
michaellukashov commentedMar 11, 2017
•
edited
Problem description:
"Edit console output" shows empty output.
Steps to reproduce:
Run ConEmu with Far1,
Run any console program,
Pick "Plugin commands" -> "ConEmu" --> "Edit console output" command
Actual results
Far1 shows empty editor
Expected results
Far1 editor window with console output.