/ConEmu

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When GetConsoleKeyboardLayoutName not implemented stop calling it #1303

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lordjeb @Maximus5
@lordjeb
Contributor

lordjeb commented Oct 29, 2017

This eliminates recurring calls to GetConsoleKeyboardLayoutName when we get an error code that indicates that it is not implemented. These calls result in a bunch of debug out messages that appear in kernel debuggers (or DbgView when capturing the same events).

I've tested it on Windows 10 RS2 and verified that prior to my fix, the debug out matches that described in #1236. After my fix, the debug out messages about a deprecated and not implemented API call are no longer there.

Note that this does NOT fix the other debug message in the issue, about a bad handle from a call to GetConsoleDisplayMode. I concur with the issue comments that this one is a Microsoft issue that can't be fixed short of not calling that API at all.

Maximus5 added a commit that referenced this pull request Nov 7, 2017

@lordjeb @Maximus5
gh-1236, gh-1303: When GetConsoleKeyboardLayoutName not implemented s… 
…top calling it
000bee5

@Maximus5 Maximus5 closed this Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment