New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Size & Pos UI; use max buffer height by default #1604

Merged
merged 3 commits into from Jun 16, 2018

Conversation

Projects
None yet
3 participants
@shawwn
Contributor

shawwn commented Jun 14, 2018

  • When users enter 99999 for console buffer height, 32766 is substituted.

  • When users enter 222222 or 111111 for console buffer height, 32766 is used instead.

  • New buffers spawn with 32766 as console buffer height

@shawwn

This comment has been minimized.

Contributor

shawwn commented Jun 14, 2018

Related to #393

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Jun 14, 2018

I don't think your patch is working. Have you checked it and how?

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Jun 14, 2018

You may ping me on Twitter or LinkedIn. But I think that GitHub is perfect for conversation.

Let me explain. Unless ConEmu architecture is fully rewritten and it depends on conhost, there is absolutely no way to create buffer longer than 32K lines.

But there are good news: Microsoft console team is working on new API and ConEmu part will become somewhat easier.

@shawwn

This comment has been minimized.

Contributor

shawwn commented Jun 14, 2018

The patch is working. I quickly realized it was impossible to create buffers larger than 32k. Instead, I improved the UI, and default to maximum size instead of 9999.

@@ -89,7 +89,7 @@ LRESULT CSetPgSizePos::OnInitDialog(HWND hDlg, bool abInitial)
checkDlgButton(hDlg, cbLongOutput, gpSet->AutoBufferHeight);
TODO("Надо бы увеличить, но нужно сервер допиливать");
SendDlgItemMessage(hDlg, tLongOutputHeight, EM_SETLIMITTEXT, 5, 0);
SendDlgItemMessage(hDlg, tLongOutputHeight, EM_SETLIMITTEXT, 6, 0);

This comment has been minimized.

@Maximus5

Maximus5 Jun 14, 2018

Owner

Than you should rollback this change

This comment has been minimized.

@shawwn

shawwn Jun 14, 2018

Contributor

Hi, see my reply at #1604 (comment)

This can't be rolled back without breaking the UI when the user enters 222222 or 111111. Users do that when they want to set the output height to maximum value (which is 32766 in this case).

@shawwn

This comment has been minimized.

Contributor

shawwn commented Jun 14, 2018

This change is necessary. When the user enters 222222 or 111111, ConEmu now switches to 32766.

If we revert this, users will get confused when they try to enter 222222. The user’s goal is to max out the value. Without this change, 222,222 will max out at 22,222, not 32,766 as expected.

Same for 111111.

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Jun 14, 2018

That makes sense

@Maximus5 Maximus5 merged commit 202e61c into Maximus5:master Jun 16, 2018

@Maximus5 Maximus5 added the settings label Jun 17, 2018

@tenpaiyomi

This comment has been minimized.

tenpaiyomi commented Oct 4, 2018

@shawwn If I may inquire, why is the max 32,766? I'm used to unlimited scrollback, so the number seems kind of odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment