New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dots in New console... because it is an immediate action without dialog #701

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@amynbe

amynbe commented May 29, 2016

"New console..." menu item suggests you will be able to select which task you want to open, which is not the case.
This PR fixes the text, but it would be useful to add a menu entry to be able to select which action to start.

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented May 29, 2016

Absolutely wrong patch. It does not take into account confirmation option!

@amynbe

This comment has been minimized.

amynbe commented May 29, 2016

Oh, sorry about that. I didn't notice there was an option to confirm. So should the "..." appear only when the option is ticked? (I'm asking to know what you think but unfortunately I don't have a C++ environment to make the change).
Other possibilities would be :

  • Remove the menu item and rely on the green "+" button that already allows to confirm or not.
  • Have 2 menu items: "New default console" and "New console..."

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment