New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for grouped results to highlight detection #1817

Open
Maximus5 opened this Issue Jul 31, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@Maximus5
Owner

Maximus5 commented Jul 31, 2015

Originally reported on Google Code with ID 1818

If I do:

$ git grep --heading --color --line-number PATTERN
SOME_FILE:
4: blah blah PATTERN
30: wibble wibble PATTERN
ANOTHER_FILE:
10: foo bar PATTERN baz

could you detect a number at the start of the line (the colon is colored) and find
the filename above it, so that the filename and the line numbers could be linkified?

Reported by sam.hasler on 2014-11-18 13:26:05

@Maximus5 Maximus5 self-assigned this Jul 31, 2015

@Maximus5 Maximus5 added the Type-Other label Jul 31, 2015

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Jul 31, 2015

oops, git grep does not output a colon after the filename.

Reported by sam.hasler on 2014-11-18 13:27:30

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Jul 31, 2015

May be... Thought it will be nice with git diff rows too.
But now detector operates with visible screen only. The file name may be high above.

Reported by ConEmu.Maximus5 on 2014-11-18 14:07:02

@Maximus5

This comment has been minimized.

Owner

Maximus5 commented Jul 31, 2015

visible screen would be acceptable, if it's more than that I'd want to grep again with
a more restrictive pattern.

Reported by sam.hasler on 2014-11-26 12:45:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment