Skip to content

Conversation

@davidhorstmann-arm
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm commented Aug 19, 2025

Add more detail around how generation of configuration-independent files chooses a C compiler. Mention that setting HOSTCC or CC is recommended where there are multiple toolchains.

Mention that the fallback location is the cc executable, which may help users troubleshooting when the file generation picks up the wrong toolchain (as in #10360).

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required because: Documentation only
  • development PR provided Clarify use of CC and friends for file generation #10365
  • TF-PSA-Crypto PR not required because TF-PSA-Crypto uses CMake and detects its own compiler
  • framework PR not required
  • 3.6 PR here
  • tests not required because: Documentation only

Add more detail around how generation of configuration-independent files
chooses a C compiler. Mention that setting HOSTCC or CC is recommended
where there are multiple toolchains.

Mention that the fallback location is the cc executable, which may help
users troubleshooting when the file generation picks up the wrong
toolchain (as in Mbed-TLS#10360).

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) labels Aug 19, 2025
@yanesca
Copy link
Contributor

yanesca commented Aug 19, 2025

I think the target branch was accidentally left at development, we should change it to mbedtls-3.6.

@davidhorstmann-arm davidhorstmann-arm changed the base branch from development to mbedtls-3.6 August 20, 2025 08:38
@davidhorstmann-arm
Copy link
Contributor Author

Whoops, thanks for catching that! I have fixed it.

Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca yanesca added needs-ci Needs to pass CI tests approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Aug 20, 2025
@davidhorstmann-arm davidhorstmann-arm added this pull request to the merge queue Aug 20, 2025
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 54bf8ad Aug 20, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests size-xs Estimated task size: extra small (a few hours at most)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants