New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data interface database synchronization script #24

Open
wants to merge 1 commit into
base: update-subscription
from

Conversation

Projects
None yet
2 participants
@AlphaHydrae
Member

AlphaHydrae commented Oct 9, 2018

See the new documentation in the development guide and README.

The following additional changes have been made:

  • The ESLint configuration has been updated to support the object rest
    spread operator (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#Spread_in_object_literals).
  • The get function in config/index.js has been renamed to
    getEnvVar for clarity.
  • The buildDatabaseUrl function in config/index.js has been renamed
    to getDatabaseUrl and is now used to retrieve both the project's
    database URL and the database URL of the data collection interface.
  • Database migration to make the theme_id column in the actions
    table not nullable.
  • Minor improvements to logging of database queries, encapsulated in the
    logQueries function in utils/knex.js.

Task: TG-117

@AlphaHydrae AlphaHydrae requested a review from Tazaf Oct 9, 2018

@coveralls

This comment has been minimized.

coveralls commented Oct 9, 2018

Coverage Status

Coverage decreased (-0.3%) to 92.715% when pulling ec368eb on db-sync into 5429755 on update-subscription.

Add data interface database synchronization script
See the new documentation in the development guide and README.

The following additional changes have been made:

* The ESLint configuration has been updated to support the object rest
  spread operator (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#Spread_in_object_literals).
* The `get` function in `config/index.js` has been renamed to
  `getEnvVar` for clarity.
* The `buildDatabaseUrl` function in `config/index.js` has been renamed
  to `getDatabaseUrl` and is now used to retrieve both the project's
  database URL and the database URL of the data collection interface.
* Database migration to make the `theme_id` column in the `actions`
  table not nullable.
* Minor improvements to logging of database queries, encapsulated in the
  `logQueries` function in `utils/knex.js`.

Task: TG-117

@AlphaHydrae AlphaHydrae changed the base branch from sprint-2-discovering-actions to update-subscription Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment