New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP::Request::Common 6.03 breaks MediaWiki::Bot #39

Closed
doherty opened this Issue Mar 31, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@doherty
Member

doherty commented Mar 31, 2012

New newline-handling introduced in HTTP::Request::Common 6.03 causes the page text sent to the server to be different than what we sent. The MD5 we calculated no longer matches, and the server rejects the edit.

There is already a bug open for this issue, but it looks like there is some pushback. We might need to do the same newline transformation before we take the MD5 in order to make it match correctly. For now, we will mark the test as TODO or something.

@doherty

This comment has been minimized.

Show comment
Hide comment
@doherty

doherty Mar 31, 2012

Member

The relevant change: https://metacpan.org/diff/release/GAAS/HTTP-Message-6.02/GAAS/HTTP-Message-6.03#lib/HTTP/Request/Common.pm

Also, making the test TODO or whatever isn't going to be enough - we need to:

  • possibly detect and work around HTTP::Request::Common 6.03
  • somehow get the MD5s to match so the edit goes through
Member

doherty commented Mar 31, 2012

The relevant change: https://metacpan.org/diff/release/GAAS/HTTP-Message-6.02/GAAS/HTTP-Message-6.03#lib/HTTP/Request/Common.pm

Also, making the test TODO or whatever isn't going to be enough - we need to:

  • possibly detect and work around HTTP::Request::Common 6.03
  • somehow get the MD5s to match so the edit goes through
@doherty

This comment has been minimized.

Show comment
Hide comment
@doherty

doherty Apr 8, 2012

Member

worked around in 3.5.1

Member

doherty commented Apr 8, 2012

worked around in 3.5.1

@doherty doherty closed this Apr 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment