New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few HTTP response fixes #63

Merged
merged 1 commit into from Jul 11, 2016

Conversation

Projects
None yet
3 participants
@benpickles
Contributor

benpickles commented Jul 11, 2016

Thanks for these docs they were good enough for me to build a Ruby API client without even hitting the actual API. While doing so I encountered and fixed these minor issues:

  • A couple of JSON syntax and formatting ditties.
  • Ensure valid HTTP responses by adding a line between headers and body (makes them copy/pastable as mock HTTP responses).
  • (I didn’t modify the HTTP requests as they appear to be intentionally formatted for readability)
Ensure valid HTTP responses:
- A couple of JSON syntax and formatting ditties.
- Ensure valid HTTP responses by adding a line between headers and body (makes them copy/pastable as mock HTTP responses).
@benmedium

This comment has been minimized.

Show comment
Hide comment
@benmedium

benmedium Jul 11, 2016

Contributor

Hi Ben! Thanks so much for this!

Would you mind signing our CLA? Sorry for the extra step! https://github.com/Medium/opensource/blob/master/sign-cla.md

Contributor

benmedium commented Jul 11, 2016

Hi Ben! Thanks so much for this!

Would you mind signing our CLA? Sorry for the extra step! https://github.com/Medium/opensource/blob/master/sign-cla.md

@benmedium benmedium merged commit f22bb16 into Medium:master Jul 11, 2016

@VSESLAW

This comment has been minimized.

Show comment
Hide comment
@VSESLAW

VSESLAW Apr 3, 2017

Это ошибка?

VSESLAW commented on README.md in 9f43ac3 Apr 3, 2017

Это ошибка?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment