Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressing 'x' key sometimes produces no sound #144

Closed
andy5995 opened this issue Jan 31, 2017 · 7 comments
Closed

pressing 'x' key sometimes produces no sound #144

andy5995 opened this issue Jan 31, 2017 · 7 comments

Comments

@andy5995
Copy link
Contributor

@andy5995 andy5995 commented Jan 31, 2017

i've noticed more than a few times that pressing 'x' and clicking on the map (sometimes) produces no sound.

Jammy commented in IRC that he also has noticed this.

I tried reproducing in a game with filux today, but failed.

If anyone else notices this on the git version, please mention it, and try to note what you were doing at the time.

I can't say exactly what I was doing at the time, but will pay more attention in the future.

Update: this happened again today during the first game of the day on git. It only seems to happen during battle, so I assume a sound conflict.

I have yet to determine if other players hear the sound, even though it doesn't sound for the person pressing the 'x'.

Update: this happened to me on 3.12 today

@titiger
Copy link
Member

@titiger titiger commented Feb 1, 2017

Technical problem with this is we cannot playback all needed sounds. You typically can play back 5,8 or whatever sounds side by side ( depends on hardware ). So if units are fighting you hear sounds form every unit and ... the alarm sound. But if there are already too many "normal" sounds in the queue you don't playback of the important alarm sound is not played back. At the moment I have no idea how to fix it. Maybe we can play back sounds with different priority or something like this or keep one sound channel free for those important sounds.

@andy5995
Copy link
Contributor Author

@andy5995 andy5995 commented Feb 1, 2017

Understood. I assume this means it will sound for the other players, unless they too have too many sounds at that time.

titiger added a commit that referenced this issue Feb 2, 2017
@titiger
Copy link
Member

@titiger titiger commented Feb 2, 2017

I tried to fix it, please test and give feedback.

@andy5995
Copy link
Contributor Author

@andy5995 andy5995 commented Feb 5, 2017

Some testing, but not much yet. So far, so good.

@andy5995
Copy link
Contributor Author

@andy5995 andy5995 commented Feb 10, 2017

I'm not sure yet. Sometimes it seems not to work, but works a lot more reliably and frequently than before.

@titiger
Copy link
Member

@titiger titiger commented Feb 19, 2017

so I mark this as fixed for now ?

@andy5995
Copy link
Contributor Author

@andy5995 andy5995 commented Feb 20, 2017

Yes.

@titiger titiger closed this Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants