Attack boosts and upgrades now support upgrading attack speed #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The syntax is the same as for other upgrades, eg:
and
Note thatvalue-percent-multiplieris broken at time of writing, but that is not the fault of this change (it's broken in thedevelopbranch).EDIT: Not a bug. I misunderstood how
value-percent-multiplierworks. It always increases by a multiple, rather than actually multiplying.As per the other upgrade tags, the
attack-speedtag is optional. The animation speed scales the same as the attack speed does.There's quite a bit of code, but most of it is adapted from the existing upgrade code.
@titiger, there are some cases of floats being used here (since we discussed how differences in handling floats in client computers could cause out of syncs), but that is because the existing upgrade code is using doubles in that way. It seems like a bad idea to introduce inconsistency on a per line basis. Much of the code in this pull request is only minor tweaks from the very similar code for the other upgrade stats.