Fixes from nephila/django-cms-themes #5

Merged
merged 4 commits into from May 12, 2012

Conversation

Projects
None yet
3 participants
Contributor

hsk81 commented Apr 3, 2012

Hi Mark,

I took the liberty to send you nephila's fixes as a pull request. I'd trouble with issue #3 which nephila seems to have fixed, but I did not see any corresponding pull request from his side.

In addition have added one "fix" on my own which tells the OS environment to use Python 2 instead of Python 3; I don't know if some (older) setups will have trouble with

#!/usr/bin/env python2

but if so just ignore my related commit 95af1be.

Contributor

yakky commented Apr 14, 2012

Yes, basically i didn't requested pull for the commits because i feel it's a very ugly hack, but I haven't had time to find a better solution since then.

Contributor

hsk81 commented Apr 17, 2012

So you think I should close the pull request? Still think your tweak has value .. it solved my problem.

Contributor

yakky commented Apr 17, 2012

I'm still +1
I commited because it solves a problem, and it's one step in the right direction.
So I do hope MegaMark16 would accept this.

@MegaMark16 MegaMark16 added a commit that referenced this pull request May 12, 2012

@MegaMark16 MegaMark16 Merge pull request #5 from hsk81/master
Fixes from nephila/django-cms-themes
30ea272

@MegaMark16 MegaMark16 merged commit 30ea272 into MegaMark16:master May 12, 2012

Owner

MegaMark16 commented May 12, 2012

Thanks @hsk81 and @nephila, sorry it took so long for me to get around to merging the fix, but it works like a charm, and honestly the whole thing is kind of a hack, so it fits right in :-)

Thanks!
Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment