Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle Armor Heavy Flamer only raise 2 heat per hit #1353

Closed
binaryspica opened this issue May 29, 2019 · 3 comments · Fixed by #1371

Comments

@binaryspica
Copy link
Contributor

commented May 29, 2019

Environment

Ver 0.45.4
Windows 7

Description

As title says. Heavy Flamer says it raises heats as much as it can normally damages, but Battle Armor Heavy Flamer only raise 2 heat per hit when I choose to raise the heat.

neoancient added a commit that referenced this issue Jun 7, 2019
The flamer weapon handler always applies two points of heat damage. The
BA heavy flamer should get four points, and the ER flamers should do
half damage when used in heat mode (TacOps, 312). The ammo-based flamers
(vehicle, heavy) use a different handler which applies the correct
damage.

Fixes #1353: Battle Armor Heavy Flamer only raise 2 heat per hit
@neoancient

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

While working on this I noticed that the ER flamer also does two points in heat mode, but ER flamers are supposed to do half damage in heat mode.

@neoancient

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Save game with an assortment of flamers and targets.
flamer_test.sav.gz

@binaryspica

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

Well, while viewing at the heat damage code, it seems that only mechs are suffered by heat, not aero and small craft. Can you review this?

on FlamerHeatHandler.java , line 60 says

if ((entityTarget instanceof Mech)

So it only checks if the target is mech. It is diffrent with PlasmaRifleHandler.java, which has

    if (!missed

&& ((entityTarget instanceof Mech) || (entityTarget instanceof Aero))) {

So... are both of these needs to be fixed?

f

And, I have checked flamer(heat mode)against aerospace fighter and confirmed that it only damages, not raise heats.

neoancient added a commit that referenced this issue Jun 10, 2019
The flamer weapon handler always applies two points of heat damage. The
BA heavy flamer should get four points, and the ER flamers should do
half damage when used in heat mode (TacOps, 312). The ammo-based flamers
(vehicle, heavy) use a different handler which applies the correct
damage.

Fixes #1353: Battle Armor Heavy Flamer only raise 2 heat per hit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.