Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink save game sizes by using XStream's ID_REFERENCES #1412

Merged

Conversation

@sixlettervariables
Copy link
Member

commented Jul 14, 2019

Currently MegaMek uses XStream's default means of serializing object graphs, which uses relative XPath references. During testing of larger aerospace games this resulted in a fair amount of save game bloat, and many object references were duplicated rather than being coalesced. This switches to using ID_REFERENCES which results in a cleaner, smaller XML file for save games. It also makes diffing save games much cleaner.

@sixlettervariables

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

As a note to those reading this PR in the future, this breaks savegame compatibility; however, we do not guarantee that between releases.

@sixlettervariables sixlettervariables merged commit ec0e57a into MegaMek:master Jul 15, 2019
2 checks passed
2 checks passed
LGTM analysis: Java No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.