Protomechs #212
Merged
Protomechs #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show kg/point instead of points/ton for protos.
They do not tie critical slots directly to equipment like other units and could not use the same critical lists on the build tab.
Instead of recreating all the components, leave them where they are and update the contents.
Also don't present the option to delete JJ or EDP, which are done in the MP and armor panels.
Set movement mode to biped for new proto.
neoancient
requested review from
AaronGullickson,
NickAragua and
sixlettervariables
Conflicts: src/megameklab/com/util/EquipmentTableModel.java src/megameklab/com/util/UnitUtil.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds protomechs as a construction option.
Protomechs handle crit slots differently than other units and required some custom classes for the build tab that work differently than other units and some modifications to drag and drop support for it. This is how MML has typically handled things in the past, and a lot of my work in the past year or two has involved consolidating nearly identical classes to remove redundant code. But in this case the functionality differs enough to make separate classes necessary.
Instead of adding another preview tab for protomechs I consolidated the preview tabs into a single one, since they were for all practical purposes identical. The various EquipmentTab classes are probably the largest outstanding example of redundant code, and in this case I wrote a generic version that can be used for most unit types (infantry have unique needs). Since switching to the new generic equipment tab is more that an incidental change it is currently only used by protomechs, and I intend to remove the individual mech, vee, and aerospace EquipmentTab classes in a future update.