Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquired Units can never be paid for #967

Closed
swang300 opened this issue Oct 9, 2018 · 2 comments

Comments

@swang300
Copy link
Contributor

commented Oct 9, 2018

In Campaign:1997, the order of operations for the if statement results in acquiring a unit to always return false from "canPayFor". Acquiring for a part works correctly (because the && is attached to the second part of the ||.

Pulling the actual canPayFor check into a separate check from the "is the options set up so I have to worry about this" check makes it more readable. I will submit a pull request.

@swang300

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2018

#968 Pull request created

swang300 added a commit to swang300/mekhq that referenced this issue Oct 10, 2018
@sixlettervariables

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

Fixed by #968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.