Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arbitrary contract score modifier #760

Merged
merged 1 commit into from Jul 8, 2018

Conversation

@Qwertronix
Copy link
Contributor

commented Jun 19, 2018

Adds a simple spinner found in the "Edit Mission" dialog for the player to set a custom, arbitrary contract score modifier, mostly as a "crutch" to handle conditions not currently covered by MekHQ for now.

Looks like this, in a new GM-created Contract that started at the usual contract score of 1:
image

@NickAragua

This comment has been minimized.

Copy link
Member

commented Jun 19, 2018

Why not just give the ability to directly set the contract score instead?

@Qwertronix

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2018

The contract score is calculated on every getScore() call based on scenario results, contract breaches, etc. rather than being incremented or decremented by the events. So it would take a bit more rework that might not be functionally identical to what the code does currently in order to have the user "set" the score directly, and then some more to have subsequent events/scenarios continue to adjust that score after the user has changed it.

An additive/subtractive modifier seemed altogether the path of least resistance with the current contract implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.