Generic Typing for SelectList bound value #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the binding of the intended output value type directly instead of capturing in a generic object to be projected later. This makes it easier to bind directly to an object field or property. This is part of a custom version of the selectlist I am using in production. I would like to provide the rest of it if this is well received.
Had the wrong check for ValueField being null.
|
Tested and it's working fine. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some other changes (improvements?) that exist in my custom version of this component, but I have not been able to get selenium or jekyll to work on windows according to the contributing instructions, and so I decided to limit to a small change for my first contribution.
Thank you for all your hard work, I hope this small bit helps!