Skip to content

Add support for Extended Item View #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 15, 2025

Conversation

cassiancc
Copy link

@cassiancc cassiancc commented Jun 11, 2025

Extended Item View is a new recipe viewer focused on 1.21.4 and above, with a lightweight API than something like REI. As its my current preferred recipe viewer, and FDRF supports a large variety of recipe viewers on early versions, I talked to Calico about integrating it into FDRF and was given the go-ahead to make a PR. It should be ready to go!

  • Cooking Pot recipes are fully working as intended.
  • Cutting Board recipes are fully working as intended.
  • Info Recipes have been added. As EIV does not contain its own info recipes at this point, these are custom.
  • Decomposition recipes are fully working as intended.

Clarification note: Unlike similar recipe viewers, EIV scales textures that have been provided to it instead of cropping them. This made it impossible to use JEI's textures directly.

@cassiancc cassiancc changed the title Add support for Extended item View Add support for Extended Item View Jun 11, 2025
@cassiancc cassiancc marked this pull request as ready for review June 11, 2025 17:23
@MerchantCalico MerchantCalico self-assigned this Jun 12, 2025
Copy link
Collaborator

@MerchantCalico MerchantCalico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior of requiring the container is inconsistent with other recipe viewers, I can't quite tell where in the code this behavior is.
EIV Transfer Requirements for Apple Cider

@cassiancc
Copy link
Author

cassiancc commented Jun 12, 2025

Cooking Pot filling requiring the container should now be resolved - that was a bug.
edit: nope, not sure what's causing that.

Copy link
Collaborator

@MerchantCalico MerchantCalico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the two fixes that have been made (thank you to the EIV dev for assisting with one, the other is a workaround). Looks approved.

@MerchantCalico MerchantCalico merged commit 3a20340 into MehVahdJukaar:fabric/1.21.5 Jun 15, 2025
@cassiancc cassiancc deleted the eiv branch July 26, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants