Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raw component props #617

Merged
merged 2 commits into from Jun 15, 2018

Conversation

Projects
None yet
2 participants
@thundernet8
Copy link
Contributor

commented Jun 10, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

将mpvue写的vue组件转换为小程序原生组件并给原生小程序引用,发现无法传递props,查询发现normalizeProperties方法取vue中定义的props时取的properties,但是如果我还是用vue习惯的props来定义属性的话实际运行时发现vue vm实例上提供的是props,就取不到值了

#320

@thundernet8

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2018

intro.png

@thundernet8

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2018

测试可以使用这个脚手架

@anchengjian anchengjian merged commit 17602b7 into Meituan-Dianping:develop Jun 15, 2018

@anchengjian

This comment has been minimized.

Copy link
Member

commented Jun 15, 2018

发现你的代码不能跑过 npm run test:mpvue ,就不 revert 了, 直接调整了一下 normalizeProperties 方法,ddf6541 还请再测试一下。
最后,感谢PR。

sexdevil pushed a commit to sexdevil/mpvue that referenced this pull request Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.