Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom logout page #17

Merged
merged 3 commits into from Jan 2, 2020
Merged

Create custom logout page #17

merged 3 commits into from Jan 2, 2020

Conversation

@angustrau
Copy link
Member

angustrau commented Jan 2, 2020

Fixes #13

@angustrau angustrau requested a review from Dalordish Jan 2, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #17 into master will increase coverage by 0.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   62.25%   62.97%   +0.71%     
==========================================
  Files          40       40              
  Lines         877      894      +17     
  Branches       86       86              
==========================================
+ Hits          546      563      +17     
  Misses        327      327              
  Partials        4        4
Flag Coverage Δ
#unittests 62.97% <ø> (+0.71%) ⬆️
Impacted Files Coverage Δ
rcjaRegistration/schools/tests.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a55b196...b742ccd. Read the comment docs.

@Dalordish Dalordish merged commit 3e0ed20 into master Jan 2, 2020
3 checks passed
3 checks passed
build
Details
codecov/patch Coverage not affected when comparing a55b196...b742ccd
Details
codecov/project 62.97% (+0.71%) compared to a55b196
Details
@Dalordish

This comment has been minimized.

Copy link
Contributor

Dalordish commented Jan 2, 2020

Thanks, and good work. Worth noting that this changes the admin logout page too.

@Dalordish Dalordish deleted the logout-page branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.