New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: 1235810 Allow to override build date #515

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
6 participants
@bmwiedemann
Contributor

bmwiedemann commented Nov 26, 2017

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This date call only works with GNU date.

Signed-off-by: Bernhard M. Wiedemann bwiedemann@suse.de

Without this patch, building the libvma package on openSUSE Linux would always produce differing results with a diff like

/usr/share/doc/packages/libvma-8.4.8/VMA_VERSION        2017-11-14 12:00:00.000000000 +0000
@@ -1,4 +1,4 @@
VMA VERSION: 8.4.8-0
VMA SVN-REVISION: 8
-BUILD DATE: Nov/26/2017 08:02:24
+BUILD DATE: Jan/01/2019 21:18:51
Allow to override build date
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This date call only works with GNU date.

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
@mellanox-github

This comment has been minimized.

Show comment
Hide comment
@mellanox-github

mellanox-github Nov 26, 2017

Collaborator

Can one of the admins verify this patch?

Collaborator

mellanox-github commented Nov 26, 2017

Can one of the admins verify this patch?

@swx-jenkins2

This comment has been minimized.

Show comment
Hide comment
@swx-jenkins2

swx-jenkins2 Nov 26, 2017

Can one of the admins verify this patch?

swx-jenkins2 commented Nov 26, 2017

Can one of the admins verify this patch?

@liranoz12 liranoz12 requested a review from serglelv Nov 27, 2017

@rafiw

This comment has been minimized.

Show comment
Hide comment
@rafiw

rafiw Nov 27, 2017

Collaborator

bot:retest

Collaborator

rafiw commented Nov 27, 2017

bot:retest

@serglelv

This comment has been minimized.

Show comment
Hide comment
@serglelv

serglelv Nov 27, 2017

Contributor

The patch enables SDE on openSUSE. Should work correctly for other distros as well.

Contributor

serglelv commented Nov 27, 2017

The patch enables SDE on openSUSE. Should work correctly for other distros as well.

@serglelv

The patch enables SDE on openSUSE. Should work correctly for other distros as well.

@swx-jenkins2

This comment has been minimized.

Show comment
Hide comment
@swx-jenkins2

swx-jenkins2 Nov 27, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1869/ for details (Mellanox internal link).

swx-jenkins2 commented Nov 27, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1869/ for details (Mellanox internal link).

@serglelv

This comment has been minimized.

Show comment
Hide comment
@serglelv

serglelv Nov 27, 2017

Contributor

bot:retest

Contributor

serglelv commented Nov 27, 2017

bot:retest

@swx-jenkins2

This comment has been minimized.

Show comment
Hide comment
@swx-jenkins2

swx-jenkins2 Nov 27, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1871/ for details (Mellanox internal link).

swx-jenkins2 commented Nov 27, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1871/ for details (Mellanox internal link).

@serglelv

This comment has been minimized.

Show comment
Hide comment
@serglelv

serglelv Nov 27, 2017

Contributor

bot:retest

Contributor

serglelv commented Nov 27, 2017

bot:retest

@swx-jenkins2

This comment has been minimized.

Show comment
Hide comment
@swx-jenkins2

swx-jenkins2 Nov 27, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1875/ for details (Mellanox internal link).

swx-jenkins2 commented Nov 27, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1875/ for details (Mellanox internal link).

@liranoz12 liranoz12 changed the title from Allow to override build date to issue: 1235810 Allow to override build date Dec 6, 2017

@liranoz12

This comment has been minimized.

Show comment
Hide comment
@liranoz12

liranoz12 Dec 6, 2017

Collaborator

bot:retest

Collaborator

liranoz12 commented Dec 6, 2017

bot:retest

@swx-jenkins2

This comment has been minimized.

Show comment
Hide comment
@swx-jenkins2

swx-jenkins2 Dec 7, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1895/ for details (Mellanox internal link).

swx-jenkins2 commented Dec 7, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1895/ for details (Mellanox internal link).

@liranoz12

This comment has been minimized.

Show comment
Hide comment
@liranoz12

liranoz12 Dec 7, 2017

Collaborator

bot:retest

Collaborator

liranoz12 commented Dec 7, 2017

bot:retest

@swx-jenkins2

This comment has been minimized.

Show comment
Hide comment
@swx-jenkins2

swx-jenkins2 Dec 7, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1899/ for details (Mellanox internal link).

swx-jenkins2 commented Dec 7, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1899/ for details (Mellanox internal link).

@liranoz12

This comment has been minimized.

Show comment
Hide comment
@liranoz12

liranoz12 Dec 10, 2017

Collaborator

bot:retest

Collaborator

liranoz12 commented Dec 10, 2017

bot:retest

@swx-jenkins2

This comment has been minimized.

Show comment
Hide comment
@swx-jenkins2

swx-jenkins2 Dec 10, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1902/ for details (Mellanox internal link).

swx-jenkins2 commented Dec 10, 2017

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/accl-libvma-pr/1902/ for details (Mellanox internal link).

@liranoz12 liranoz12 merged commit 251d618 into Mellanox:master Dec 11, 2017

0 of 2 checks passed

MellanoxLab Build finished.
Details
MellanoxLab-RedmineChecker Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment