From 00cc60503e5e55d0476a9611400170c4932ea0dc Mon Sep 17 00:00:00 2001 From: TheGeka Date: Tue, 26 Aug 2025 13:36:16 +0200 Subject: [PATCH 1/3] Only require ca certificate when using verify-ca or verify-full --- tap_postgres/tap.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tap_postgres/tap.py b/tap_postgres/tap.py index 6c2c81a4..eb20f36c 100644 --- a/tap_postgres/tap.py +++ b/tap_postgres/tap.py @@ -396,10 +396,11 @@ def get_sqlalchemy_query(self, config: Mapping[str, Any]) -> dict: if config["ssl_enable"]: ssl_mode = config["ssl_mode"] query.update({"sslmode": ssl_mode}) - query["sslrootcert"] = self.filepath_or_certificate( - value=config["ssl_certificate_authority"], - alternative_name=config["ssl_storage_directory"] + "/root.crt", - ) + if ssl_mode in ("verify-ca", "verify-full") and config.get("ssl_certificate_authority"): + query["sslrootcert"] = self.filepath_or_certificate( + value=config["ssl_certificate_authority"], + alternative_name=config["ssl_storage_directory"] + "/root.crt", + ) # ssl_client_certificate_enable is for verifying the client's identity to the # server. From e627fb43b3f4dff63944b12d3974535432d76f53 Mon Sep 17 00:00:00 2001 From: TheGeka Date: Tue, 26 Aug 2025 13:49:47 +0200 Subject: [PATCH 2/3] Fix linter complaining line is too long --- tap_postgres/tap.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tap_postgres/tap.py b/tap_postgres/tap.py index eb20f36c..9096f3b9 100644 --- a/tap_postgres/tap.py +++ b/tap_postgres/tap.py @@ -396,7 +396,10 @@ def get_sqlalchemy_query(self, config: Mapping[str, Any]) -> dict: if config["ssl_enable"]: ssl_mode = config["ssl_mode"] query.update({"sslmode": ssl_mode}) - if ssl_mode in ("verify-ca", "verify-full") and config.get("ssl_certificate_authority"): + if ( + ssl_mode in ("verify-ca", "verify-full") + and config.get("ssl_certificate_authority") + ): query["sslrootcert"] = self.filepath_or_certificate( value=config["ssl_certificate_authority"], alternative_name=config["ssl_storage_directory"] + "/root.crt", From 347573f55e930e39fa21bc63746fd5ee896cab34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Ram=C3=ADrez=20Mondrag=C3=B3n?= Date: Wed, 27 Aug 2025 14:22:11 -0600 Subject: [PATCH 3/3] chore: Format --- tap_postgres/tap.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tap_postgres/tap.py b/tap_postgres/tap.py index 9096f3b9..4dea1188 100644 --- a/tap_postgres/tap.py +++ b/tap_postgres/tap.py @@ -396,9 +396,8 @@ def get_sqlalchemy_query(self, config: Mapping[str, Any]) -> dict: if config["ssl_enable"]: ssl_mode = config["ssl_mode"] query.update({"sslmode": ssl_mode}) - if ( - ssl_mode in ("verify-ca", "verify-full") - and config.get("ssl_certificate_authority") + if ssl_mode in ("verify-ca", "verify-full") and config.get( + "ssl_certificate_authority" ): query["sslrootcert"] = self.filepath_or_certificate( value=config["ssl_certificate_authority"],