Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resume after playback started from non zero starting point #6

Merged
merged 1 commit into from Feb 13, 2014
Merged

Add resume after playback started from non zero starting point #6

merged 1 commit into from Feb 13, 2014

Conversation

bossanova808
Copy link
Contributor

Per this thread:
http://forum.xbmc.org/showthread.php?tid=183743&highlight=unpause+jump+back

I have added this.

I find I needed an xbmc.sleep(100) in there to make sure the currentTime call returned the currenttime - without it seems to still be at the 0 point when this is executed. I suppose that's an xbmc.bug - this makes this work, though.

Hopefully string/logging etc is ok?

@bossanova808
Copy link
Contributor Author

Apologies for the three commits - I have no idea how to squash with tortoisegit yet.

@Memphiz
Copy link
Owner

Memphiz commented Jan 20, 2014

Looks good Codewise - i dislike the sleep and will try to find the real bug.

At the end this has to be a single Commit without that merge Commit...

@bossanova808
Copy link
Contributor Author

Ok will clean up the spacing and try work out the git voodoo

@bossanova808
Copy link
Contributor Author

I got rid of the merge commit. The spacing is the file is definitely spaces and consistent, is that ok?? I can't seem to squash the second commit which was a typo fix up.

Otherwise would be easiest for me to close, re-do my changes and start fresh, cause squash just aint doing what it is told.

@Memphiz
Copy link
Owner

Memphiz commented Jan 20, 2014

@bossanova808
Copy link
Contributor Author

Ok - I think that's all good now - just one commit (I needed to rebase to one commit further back - ahd my thinking in reverse on that one) - and the spacing is consistent in that file .... so I think all good ... with the exception of the sleep hack which is above my paygrade ;)

@Memphiz
Copy link
Owner

Memphiz commented Jan 21, 2014

fyi

xbmc/xbmc#4064

@bossanova808
Copy link
Contributor Author

@Memphiz thanks - much better if the sleep can be avoided. The sleep, if required, is probably too long at 100ms, I just wanted to be sure it would work on slow platforms etc.

I just updated this PR with the exclusion stuff I had not noticed really before, don't use it.

@Memphiz
Copy link
Owner

Memphiz commented Jan 23, 2014

get rid of the sleep - mainline was fixed here xbmc/xbmc#4051

@bossanova808
Copy link
Contributor Author

Great! Done.

@bossanova808
Copy link
Contributor Author

Guessing this is waiting for Gotham?

@Memphiz
Copy link
Owner

Memphiz commented Feb 12, 2014

no i am just busy ...

@Memphiz
Copy link
Owner

Memphiz commented Feb 12, 2014

Ahh just fyi - its not done by merging that PR - i need to do a pull request to the addon mailing list (which is annoying) afterwards - thats why i leave this pr open until i feel i want to do that aswell - the i do both at once ...

@bossanova808
Copy link
Contributor Author

Yep sure, been there done that. No hurry on my account, just checking.

Obviously whenever works or you. Thanks mate.

From: Memphiz [mailto:notifications@github.com]
Sent: Thursday, 13 February 2014 9:46 AM
To: Memphiz/script.xbmc.unpausejumpback
Cc: bossanova808
Subject: Re: [script.xbmc.unpausejumpback] Add resume after playback started from non zero starting point (#6)

Ahh just fyi - its not done by merging that PR - i need to do a pull request to the addon mailing list (which is annoying) afterwards - thats why i leave this pr open until i feel i want to do that aswell - the i do both at once ...


Reply to this email directly or view it on GitHub #6 (comment) . https://github.com/notifications/beacon/731309__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNzc3Nzk4OCwiZGF0YSI6eyJpZCI6MjM4MzMyMzF9fQ==--3493cf376941ea3987b6a87b65117be7b73d085a.gif

Memphiz added a commit that referenced this pull request Feb 13, 2014
Add resume after playback started from non zero starting point
@Memphiz Memphiz merged commit bfe540d into Memphiz:master Feb 13, 2014
@bossanova808
Copy link
Contributor Author

Where did we get with this - was the timestamp issue ever fixed in kodi master? Could we have another run at putting this in?

@Memphiz
Copy link
Owner

Memphiz commented Jan 21, 2015

was not fixed - dev in charge is mia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants