New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resume after playback started from non zero starting point #6
Conversation
Apologies for the three commits - I have no idea how to squash with tortoisegit yet. |
Looks good Codewise - i dislike the sleep and will try to find the real bug. At the end this has to be a single Commit without that merge Commit... |
Ok will clean up the spacing and try work out the git voodoo |
I got rid of the merge commit. The spacing is the file is definitely spaces and consistent, is that ok?? I can't seem to squash the second commit which was a typo fix up. Otherwise would be easiest for me to close, re-do my changes and start fresh, cause squash just aint doing what it is told. |
Ok - I think that's all good now - just one commit (I needed to rebase to one commit further back - ahd my thinking in reverse on that one) - and the spacing is consistent in that file .... so I think all good ... with the exception of the sleep hack which is above my paygrade ;) |
fyi |
@Memphiz thanks - much better if the sleep can be avoided. The sleep, if required, is probably too long at 100ms, I just wanted to be sure it would work on slow platforms etc. I just updated this PR with the exclusion stuff I had not noticed really before, don't use it. |
get rid of the sleep - mainline was fixed here xbmc/xbmc#4051 |
Great! Done. |
Guessing this is waiting for Gotham? |
no i am just busy ... |
Ahh just fyi - its not done by merging that PR - i need to do a pull request to the addon mailing list (which is annoying) afterwards - thats why i leave this pr open until i feel i want to do that aswell - the i do both at once ... |
Yep sure, been there done that. No hurry on my account, just checking. Obviously whenever works or you. Thanks mate. From: Memphiz [mailto:notifications@github.com] Ahh just fyi - its not done by merging that PR - i need to do a pull request to the addon mailing list (which is annoying) afterwards - thats why i leave this pr open until i feel i want to do that aswell - the i do both at once ... — |
Add resume after playback started from non zero starting point
Where did we get with this - was the timestamp issue ever fixed in kodi master? Could we have another run at putting this in? |
was not fixed - dev in charge is mia |
Per this thread:
http://forum.xbmc.org/showthread.php?tid=183743&highlight=unpause+jump+back
I have added this.
I find I needed an xbmc.sleep(100) in there to make sure the currentTime call returned the currenttime - without it seems to still be at the 0 point when this is executed. I suppose that's an xbmc.bug - this makes this work, though.
Hopefully string/logging etc is ok?